Migration Contracts Changes #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
reviewed
Sep 12, 2024
nlordell
reviewed
Sep 12, 2024
mmv08
reviewed
Sep 13, 2024
nlordell
reviewed
Sep 16, 2024
CI will fail because we are changing the asset but not adding a new chain ID or deployments. |
nlordell
reviewed
Sep 16, 2024
| @@ -115,6 +118,41 @@ describe('assets/', () => { | |||
| } | |||
| }); | |||
|
|
|||
| it('should contain the migration contracts networks in all other files', async () => { | |||
There was a problem hiding this comment.
IMO this can be part of the above test, most of the counting is duplicated anyway.
There was a problem hiding this comment.
I initially thought so, but as the intention of the tests were different, thought to have it separated (one to make sure all the deployments are present in all contracts except the migration one, while the other test makes sure the migration test deployments are also present in other contracts.)
mmv08
reviewed
Sep 18, 2024
mmv08
approved these changes
Sep 18, 2024
remedcu
added a commit
that referenced
this pull request
Sep 25, 2024
Safe deployments for the migration contracts were added in #777 but retrieving those deployments was not added. This PR adds the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new Safe Migration Contracts to the deployments of
v1.4.1. Corresponding changes have been made to the automated tests and reviews as well.