Fix: getSDKVersion bug #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ceec775 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Should I do something about the changeset? |
mmv08
approved these changes
Mar 15, 2023
mmv08
reviewed
Mar 15, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@safe-global/safe-apps-sdk", | |||
| "version": "7.10.0", | |||
| "version": "7.10.1", | |||
There was a problem hiding this comment.
The version should be bumped via changeset
There was a problem hiding this comment.
You need to create a changeset and push it to the dev branch. The changeset bot will create a PR to bump the version
katspaugh
force-pushed
the
slice-of-cake
branch
from
be0eccb
to
5ab80bb
Compare
katspaugh
force-pushed
the
slice-of-cake
branch
from
c75f70d
to
ceec775
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSDKVersionhad the wrong assumption that the package version is always 5 symbols.It can obviously be any number of symbols.
This caused issues when the Safe UI is using the latest version of the SDK, but a Safe App is using an old version that used to use semver to compare versions (and it throws).