Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FocusCaret to get caret in Chrome #593

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

PzaThief
Copy link
Contributor

@PzaThief PzaThief commented Jan 5, 2024

To solve #375 I added a logic to find caret position from Chrome via oleacc.dll.
Now Ditto can find caret from more variety application like VS, VS Code, etc.
But like as the reference that @u-Sir gave, It is not cover UWP applications yet.
So, this is just first solution of the issue (because i think Chrome is more important than any others) and I will decide whether to add a logic to support UWP apps after.

@sabrogden sabrogden merged commit ef302d2 into sabrogden:master Jan 5, 2024
1 check failed
@sabrogden
Copy link
Owner

fantastic change, what would the change be to support uwp apps?

@PzaThief
Copy link
Contributor Author

PzaThief commented Jan 6, 2024

Owner

Seems to use UIAutomation that is first time to use for both of Ditto and me. Just it.
But it is in Windows SDK, already Ditto has, so there is nothing special to do something else(perhaps).
Please understand that I am slacking off for a while hahaha

@PzaThief PzaThief deleted the fix/get-caret-in-chrome branch January 6, 2024 00:22
@sabrogden
Copy link
Owner

ok to call LoadLibrary over and over, mostly looks like yes, https://stackoverflow.com/questions/3497516/does-loadlibrary-create-distinct-instances but i've always loaded it up front and did GetProcAddress up front.

@PzaThief
Copy link
Contributor Author

PzaThief commented Jan 6, 2024

ok to call LoadLibrary over and over, mostly looks like yes, https://stackoverflow.com/questions/3497516/does-loadlibrary-create-distinct-instances but i've always loaded it up front and did GetProcAddress up front.

Thank you for suggestion! I'll fix it in next update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants