Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas m2 #7

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Canvas m2 #7

merged 11 commits into from
Jan 3, 2024

Conversation

00salmon
Copy link
Contributor

@00salmon 00salmon commented Nov 24, 2023 •
edited
Loading

Description of the change

Updated plop target colors and replaces jotai-molecules with bunshi

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Locrian24
Locrian24 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Locrian24 Locrian24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super easy changes. Just flagged a TODO but'll approve when it's removed/addressed and should include a CHANGELOG update

packages/react/src/canvas/plugins/CanvasPickAndPlopMolecule.tsx Outdated Show resolved Hide resolved
@00salmon 00salmon merged commit 70c1ed9 into main Jan 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Locrian24 Locrian24 Locrian24 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@00salmon @Locrian24 @zachharrison