Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to JUnit from TestNG #436

Merged
merged 1 commit into from
Feb 12, 2023
Merged

migrate to JUnit from TestNG #436

merged 1 commit into from
Feb 12, 2023

Conversation

siwonpawel
Copy link
Contributor

@siwonpawel siwonpawel commented Jan 22, 2023 •
edited
Loading

PR for #435

@siwonpawel siwonpawel changed the title migrate to JUnit from TestNG #435 migrate to JUnit from TestNG Jan 22, 2023
@slawekjaranowski slawekjaranowski linked an issue Jan 22, 2023 that may be closed by this pull request
Switch unit test from TestNG to JUnit 5 #435
Closed
slawekjaranowski
slawekjaranowski reviewed Jan 22, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member

@pawelsiwon please look at build result ... the same should be locally 😄

@siwonpawel
Copy link
Contributor Author

siwonpawel commented Jan 23, 2023 •
edited
Loading

Sorry for the errors, I am working on machine that was freshly configured for development (first time using MacOS) and I thought it's related to my environment. I've updated, should I squash before approval? It's my first time committing to someone's repo on GitHub.

@siwonpawel
Copy link
Contributor Author

siwonpawel commented Jan 24, 2023 •
edited
Loading

I've squashed commits, too many commit for this change

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@slawekjaranowski slawekjaranowski added the code quality Improvements, refactor or code cleanup. label Feb 12, 2023
@slawekjaranowski slawekjaranowski merged commit dc00332 into s4u:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
code quality Improvements, refactor or code cleanup.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch unit test from TestNG to JUnit 5
2 participants
@siwonpawel @slawekjaranowski