Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ncc version to fix generation of distribution #107

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Sep 5, 2024

This commit addresses the following warning:

npm warn deprecated @zeit/ncc@0.22.3: @zeit/ncc is no longer maintained. Please use @vercel/ncc instead.

and fixes the following error:

ncc: Compiling file index.js
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:79:19)
    at Object.createHash (node:crypto:139:10)
    at hashOf (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/index.js.cache.js:3:58216)
    at module.exports (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/index.js.cache.js:3:60642)
    at runCmd (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:47355)
    at 819 (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:44227)
    at __webpack_require__ (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:169)
    at startup (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:339)
    at module.exports.8 (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:371)
    at /home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:381 {
  opensslErrorStack: [
    'error:03000086:digital envelope routines::initialization error',
    'error:0308010C:digital envelope routines::unsupported'
  ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

This commit addresses the following warning:

> npm warn deprecated @zeit/ncc@0.22.3: @zeit/ncc is no longer maintained. Please use @vercel/ncc instead.

and fixes the following error:

```
ncc: Compiling file index.js
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:79:19)
    at Object.createHash (node:crypto:139:10)
    at hashOf (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/index.js.cache.js:3:58216)
    at module.exports (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/index.js.cache.js:3:60642)
    at runCmd (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:47355)
    at 819 (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:44227)
    at __webpack_require__ (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:169)
    at startup (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:339)
    at module.exports.8 (/home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:371)
    at /home/runner/work/git-publish-subdir-action/git-publish-subdir-action/action/node_modules/@zeit/ncc/dist/ncc/cli.js.cache.js:1:381 {
  opensslErrorStack: [
    'error:03000086:digital envelope routines::initialization error',
    'error:0308010C:digital envelope routines::unsupported'
  ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
```
Copy link

minder-by-stacklok bot commented Sep 5, 2024

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of 30860fc9:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

Copy link

Dependency Information

Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.

📦 Dependency: @vercel/ncc

Trusty Score: 0

Scoring details
Component Score
Malicious false
Package activity 0
Provenance 0

s0
s0 previously approved these changes Sep 6, 2024
@s0 s0 force-pushed the fix-build-updating-from-zeit-ncc-to-vercel/-ncc branch from bda77b3 to 4220bfa Compare September 7, 2024 13:28
@s0 s0 force-pushed the fix-build-updating-from-zeit-ncc-to-vercel/-ncc branch from 4220bfa to 30860fc Compare September 7, 2024 13:33
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (65d1af0) to head (30860fc).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #107      +/-   ##
===========================================
+ Coverage    90.30%   94.33%   +4.03%     
===========================================
  Files            1        1              
  Lines          196      212      +16     
  Branches        41       51      +10     
===========================================
+ Hits           177      200      +23     
+ Misses          14       12       -2     
+ Partials         5        0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s0 s0 merged commit 5f1aadc into s0:develop Sep 7, 2024
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants