Fix JetBransMono != ligature #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] In JetBrainsMono v2.242 the exclam-equal ligature is broken. It has been fixed in v3.000. [how] The JetBrains Mono v3 has not been released yet. So we just transplant the one broken glyph from v3.000 into our v2.242. [note] JetBrains/JetBrainsMono#494 Fixes: #963 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We do not want to rebuild all fonts, just the affected ones. Without a proper release timestamp this is impossible (i.e. harder) to do via CI, so do it manually 😬 [how] ./gotta-patch-em-all-font-patcher\!.sh /JetBrainsMono/Ligatures/ExtraLight ./gotta-patch-em-all-font-patcher\!.sh /JetBrainsMono/Ligatures/Light Hmm, the patched fonts got slightly smaller. These font file sizes are a mystery for me. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
To properly update repo and release candidate... |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
In JetBrainsMono v2.242 the exclam-equal ligature is broken. It has been fixed in v3.000.
[how]
The JetBrains Mono v3 has not been released yet. So we just transplant the one broken glyph from v3.000 into our v2.242.
[note]
JetBrains/JetBrainsMono#494
Fixes: #963
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)