update Intel One Mono to 1.3.0 #1558
Conversation
| @@ -700,6 +700,7 @@ class font_patcher: | |||
| 'firasans' : 'furasans', | |||
| 'IntelOneMono' : 'IntoneMono', | |||
| 'IntelOne Mono' : 'Intone Mono', | |||
| 'Intel One Mono' : 'Intone Mono', | |||
There was a problem hiding this comment.
this might not be needed actually, the release version 3.1.1 does rename it properly. should I remove it?
There was a problem hiding this comment.
Well, the legacy renaming in the font-patcher is not used, normally (probably we should remove it completely).
And the rule added by
- d3181df
name-parser: Add IntelOne replacement to SIL table
is rather forgiving ;-)
(But this change is the correct thing to do, so keep it.)
Lets compare the actual names (via [1])
======== intelone-mono-font-family-regular.ttf ========
SFNT Fullname ID 4 IntelOne Mono
SFNT Family ID 1 IntelOne Mono
SFNT SubFamily ID 2 Regular
SFNT Pref Family ID 16 -
SFNT Pref Styles ID 17 -
SFNT PS Name ID 6 IntelOneMono-Regular
SFNT Compatible ID 18 -
SFNT CID findfont ID 20 -
SFNT WWS Family ID 21 -
SFNT WWS SubFamily ID 22 -
PS fontname IntelOneMono-Regular
PS fullname IntelOne Mono
PS familyname IntelOne Mono
fondname None
======== IntelOneMono-Regular.ttf ========
SFNT Fullname ID 4 Intel One Mono
SFNT Family ID 1 Intel One Mono
SFNT SubFamily ID 2 Regular
SFNT Pref Family ID 16 -
SFNT Pref Styles ID 17 -
SFNT PS Name ID 6 IntelOneMono-Regular
SFNT Compatible ID 18 -
SFNT CID findfont ID 20 -
SFNT WWS Family ID 21 -
SFNT WWS SubFamily ID 22 -
PS fontname IntelOneMono-Regular
PS fullname Intel One Mono
PS familyname Intel One Mono
fondname None
[1] bin/scripts/name_parser/query_name
There was a problem hiding this comment.
and ...
'firasans' : 'furasans',
is technically wrong, which is good, because it is also wrong from the contents, so a bug fixes the bug ;-D
(I believe, the legacy renaming I never test)
|
Thanks for the PR, some small things I will just fix on the fly. 💚 |
[why] The fontconfig is autogenerated by the release process with the bin/scripts/generate-fontconfig.sh script. The reason is that its contents should match the released fonts (i.e. the latest release). Also: Upstream changed the name grouping a bit, so the superfluous "Bold" family has been dropped (and does not need an entry anymore). [how] Revert the (manual) change and wait for the release process to update the fontconfig. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Very nice PR, you fixed stuff I would have propably forgotten 😬 Nowadays we do not put the fonts into separate subdirs anymore, maybe this is a good time to change it for IntelOne. What do you think about the subdir structure with |
|
Oh I just noticed it is not in-repo-released anyhow... 
So I think we should drop the subdirs. |
[why] For new fonts we do not create one subdirectory for each font file anymore. The (historic) reason were the many variants that each font file had been patched with. Nowadays we just have 3 variants for each font file. And anyhow this font is release archive released only. [how] Simplify update script and move font files. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Description
updated Intel One Mono to 1.3.0, and (hopefully) fixed everything relating to its updated file names and internal family names. I may have even changed more than is needed ...
Requirements / Checklist
What does this Pull Request (PR) do?
updates Intel One Mono to 1.3.0
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)