Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Astro icon #1464

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Add Astro icon #1464

merged 3 commits into from
Mar 14, 2024

Conversation

roginfarrer
Copy link
Contributor

Description

Added an icon for Astro. I got the icon from iconify

Requirements / Checklist

What does this Pull Request (PR) do?

Added an icon for Astro.

How should this be manually tested?

Any background context you can provide?

Addresses a line item in #1095.

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator

Finii commented Dec 21, 2023

Thanks for the PR!

Is Astro the same as Astrojs (probably not) (request)

@roginfarrer
Copy link
Contributor Author

Pretty sure they are referring to the same thing. Astro is a JavaScript web framework.

@CoolPlayLin
Copy link

Any update on this?@Finii

- rename svg file to follow nameing rule
- remove color from svg
- use tabs in tsv (tab-separated-values) file :-D

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii merged commit 925e732 into ryanoasis:master Mar 14, 2024
1 check was pending
@Finii
Copy link
Collaborator

Finii commented Mar 14, 2024

@allcontributors please add @roginfarrer for code

Copy link
Contributor

@Finii

I've put up a pull request to add @roginfarrer! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants