Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to embedded-hal 1.0.0 #34

Merged
merged 5 commits into from
May 3, 2024
Merged

Update to embedded-hal 1.0.0 #34

merged 5 commits into from
May 3, 2024

Conversation

ryankurte
Copy link
Owner

updates #32

  • adds .reverse_cell() for RefCell wrapping
  • swaps pin impls to use RefCells (you can't move only the InputPin impl without causing problems, seemed simpler to always do this than to have two possible paths)

cc. @Dirbaio @MabezDev

@ryankurte ryankurte self-assigned this Apr 17, 2024
@ryankurte
Copy link
Owner Author

ryankurte commented Apr 17, 2024

hmm looks like DelayUs has caused us some MSRV problems with 1.62 related to rust-lang/rust#88581 ...

not sure why we're seeing this here but not in embedded-hal which has an MSRV of 1.60 though.

@onkoe
Copy link

onkoe commented May 1, 2024

I was getting that MSRV error when building before d706ecd. It seems to be fixed now!

Have you checked if these tests are still failing? This crate would be super handy for me. :D

edit: Ah, my apologies. Using cargo +1.69.0 build --target=x86_64-unknown-linux-gnu results in the failures denoted in the tests.

(unrelated, but I really love sparse and don't know how we lived without it 😭)

@onkoe
Copy link

onkoe commented May 1, 2024

Also, another crate hit this problem and ended up implementing their own div_ceil as a utility method. As a quick and dirty solution to allow folks to use 1.69, it might work..? https://github.com/sarah-ek/faer-rs/blob/main/src/utils/mod.rs

@eldruin
Copy link
Collaborator

eldruin commented May 2, 2024

We might also raise the MSRV to 1.73.0 (~ 6 months old) which is when div_ceil was stabilized. It might be a bit too new for a compatibility layer, but it is better than nothing. If someone really needs an older version, they can always submit a PR.

@ryankurte
Copy link
Owner Author

We might also raise the MSRV to 1.73.0

good call, let's do that and get something out / worry about prior versions if it turns out to be a problem ^_^

@ryankurte ryankurte requested a review from eldruin May 2, 2024 22:58
Copy link
Collaborator

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@eldruin eldruin merged commit 3bdada3 into main May 3, 2024
36 checks passed
@eldruin
Copy link
Collaborator

eldruin commented May 3, 2024

Is there anything missing or can we go ahead with a release?

@ryankurte ryankurte deleted the feat/embedded-hal-1.0.0 branch May 3, 2024 22:01
@ryankurte ryankurte mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants