Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude def files from coverage #1871

Merged
merged 2 commits into from
Apr 8, 2024
Merged

exclude def files from coverage #1871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae22da5
exclude def files from coverage
drazisil Apr 5, 2024
1dd2b2f
Merge branch 'main' into exclude-def-files-from-coverage
drazisil Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export default defineConfig({
"bin/**/*.ts",
"ecosystem.config.js",
"migrate.ts",
"packages/**/*.d.ts",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added a glob pattern to include all TypeScript Declaration files in all directories under 'packages'. While this is a valid change, please be aware that depending on the depth of nested folders and the number of .d.ts files, this could potentially slow down your Vite routine. If we have many nested levels and lots of .d.ts files, we might want to consider a more specific glob or a strategic directory restructure.

Copy link

@codecov codecov bot Apr 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line includes .d.ts files from the packages directory into the coverage report. However, .d.ts files are generally used for type declaration, and do not have functional logic that needs to be covered by tests. It's unusual to include these files in coverage reports, unless you have specific reason for it.

],
reporter: ["lcov", "text", "cobertura"],
},
Expand Down