Allow returning edge indices from random walk #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an optional argument in the `random_walk` function, namely `return_edge_indices`. The default behaviour is not changed, but if a user wants to directly use the edges visited by the random walker, we can return the indices of those edges by setting `return_edge_indices` to `True`. New cases are also added to the test suite.
rusty1s
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feature request in #137. The changes can be easily ported to
pyg-lib(at least in theory 😅 ), but currently, we still rely ontorch_cluster, so I added the change here first.This commit adds an optional argument in the
random_walkfunction, namelyreturn_edge_indices. The default behaviour is not changed, but if a user wants to directly use the edges visited by the random walker, we can return the indices of those edges by settingreturn_edge_indicestoTrue. New cases are also added to the test suite.