Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-precision support #119

Merged
merged 5 commits into from
Dec 28, 2021
Merged

Half-precision support #119

merged 5 commits into from
Dec 28, 2021

Conversation

rusty1s
Copy link
Owner

@rusty1s rusty1s commented Dec 28, 2021

No description provided.

@rusty1s rusty1s self-assigned this Dec 28, 2021
@rusty1s rusty1s added the enhancement New feature or request label Dec 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #119 (1f725f0) into master (0d735d7) will not change coverage.
The diff coverage is n/a.

❗ Current head 1f725f0 differs from pull request most recent head c00b1f0. Consider uploading reports for the commit c00b1f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines           77        77           
=========================================
  Hits            77        77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d735d7...c00b1f0. Read the comment docs.

@rusty1s rusty1s merged commit e8620a8 into master Dec 28, 2021
@rusty1s rusty1s deleted the half_precision branch December 28, 2021 16:58
@kami93
Copy link

kami93 commented Jan 5, 2022

I was already using torch_cluster.fps under amp.autocast context. Why was I not seeing an error?

@rusty1s
Copy link
Owner Author

rusty1s commented Jan 5, 2022

No idea :) Perhaps the input was casted to float32 under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants