Add note about using custom WebDrivers #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcrichton this change actually isn't accurate until rustwasm/wasm-pack#1127 is merged. Could you take a look at that as well please? |
|
Ah ok, I will revert this. I don't manage wasm-pack though. |
alexcrichton
added a commit
that referenced
this pull request
Apr 19, 2022
This reverts commit 8ac33c6.
|
I see. I saw your fingerprints on something over there and assumed, but I see now that I was mistaken. How would you prefer I handle this? It's a bit awkward to have two contingent PRs to different repos pending. |
|
Sorry but I don't help out with wasm-pack any more so I don't know how to coordinate the two repos. |
|
Okay then. I think what I'll do is wait for the wasm-pack PR to be resolved (it's been quite some time at this point, but hopefully someone looks at it eventually), and then resubmit this PR to update the docs. Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the docs to reflect the change made in rustwasm/wasm-pack#1127 and discussed in rustwasm/wasm-pack#1126.