Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket.send_with_u8_array should accept an immutable byte slice #2014

Closed
chinedufn opened this issue Feb 26, 2020 · 2 comments · Fixed by #2015
Closed

WebSocket.send_with_u8_array should accept an immutable byte slice #2014

chinedufn opened this issue Feb 26, 2020 · 2 comments · Fixed by #2015
Labels
bug

Comments

@chinedufn
Copy link
Contributor

Currently requires &mut [u8]

https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.WebSocket.html#method.send_with_u8_array
@chinedufn chinedufn added the bug label Feb 26, 2020
@alexcrichton
Copy link
Contributor

Sounds good to fix! I think we'll just need to update our whitelist

chinedufn added a commit to chinedufn/wasm-bindgen that referenced this issue Feb 27, 2020
@chinedufn
Whitelist send_with_u8_array slice
7810b73 
Fixes rustwasm#2014
@chinedufn chinedufn mentioned this issue Feb 27, 2020
Merged
@chinedufn
Copy link
Contributor Author

Thanks!

alexcrichton pushed a commit that referenced this issue Mar 2, 2020
@chinedufn
Whitelist send_with_u8_array slice (#2015)
bab83a7 
* Whitelist send_with_u8_array slice

Fixes #2014

* Fix send slice

* Remove chromedriver comment

* Get slice tests running in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Whitelist send_with_u8_array slice chinedufn/wasm-bindgen
2 participants
@alexcrichton @chinedufn