Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make resolve_error public API #266

Merged
merged 3 commits into from
May 9, 2024
Merged

make resolve_error public API #266

merged 3 commits into from
May 9, 2024

Conversation

rtbo
Copy link
Collaborator

@rtbo rtbo commented May 9, 2024

  • UnknownError introduced and returned if resolution fails instead of panicking
  • Better consistency between error and event API
  • Connection::resolve_error is introduced
  • cache_extensions_data is public

See #265

rtbo added 3 commits May 9, 2024 14:00
@rtbo
codegen hygiene
c18d8a4
@rtbo
make event::resolve_event a public API
5630094
@rtbo
make resolve_error a public API
a4e23bd 
 - `UnknownError` introduced and returned if resolution fails instead of panicking
 - Better consistency between error and event API

See rust-x-bindings#265
@rtbo rtbo merged commit 77a1972 into rust-x-bindings:main May 9, 2024
2 checks passed
@rtbo rtbo deleted the pub_resolve_error branch May 9, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rtbo