Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: Forward suspended() and resumed() events and patch up platform-specific documentation #3786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

android: Forward suspended() and resumed() events and patch up platform-specific documentation #3786

wants to merge 1 commit into from

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Jul 10, 2024 •
edited
Loading

Closes #3779

Key them off of onStop() and onStart() which seems to match the other backends most closely. These Android Activity lifecycle events denote when the application is visible on-screen, and recommend that any heavy lifting for startup and shutdown happens here, as the application may be demoted to the background and later shut down entirely unless the user navigates back to it.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@MarijnS95 MarijnS95 added DS - android C - waiting on author Waiting for a response or another PR S - platform parity Unintended platform differences labels Jul 10, 2024
@MarijnS95 MarijnS95 mentioned this pull request Jul 10, 2024
Open
@MarijnS95 MarijnS95 added C - needs discussion Direction must be ironed out C - nominated Nominated for discussion in the next meeting and removed C - waiting on author Waiting for a response or another PR labels Aug 11, 2024
@daxpedda daxpedda removed the C - nominated Nominated for discussion in the next meeting label Aug 23, 2024
@MarijnS95 MarijnS95 removed the C - needs discussion Direction must be ironed out label Aug 23, 2024
@madsmtm madsmtm mentioned this pull request Sep 1, 2024
Open
24 tasks
madsmtm
madsmtm approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, feel free to merge once you think it's ready!

@MarijnS95 MarijnS95 mentioned this pull request Sep 2, 2024
Draft
5 tasks
@MarijnS95 MarijnS95 marked this pull request as ready for review September 2, 2024 09:36
@MarijnS95
android: Forward suspended() and resumed() events and patch up pl…
0a2a176 
…atform-specific documentation

Key them off of `onStop()` and `onStart()` which seems to match the
other backends most closely.  These [Android Activity lifecycle] events
denote when the application is visible on-screen, and recommend that any
heavy lifting for startup and shutdown happens here, as the application
may be demoted to the background and later shut down entirely unless the
user navigates back to it.

[Android Activity lifecycle]: https://developer.android.com/guide/components/activities/activity-lifecycle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

@daxpedda daxpedda Awaiting requested review from daxpedda

Assignees
No one assigned
Labels
DS - android S - platform parity Unintended platform differences
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-platform consistency for ApplicationHandler::suspended/resumed()
3 participants
@MarijnS95 @madsmtm @daxpedda