Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenGL profile selection #567

Merged
merged 1 commit into from
Aug 13, 2015
Merged

Fix OpenGL profile selection #567

merged 1 commit into from
Aug 13, 2015

Conversation

paulrouget
Copy link
Contributor

This addresses 2 issues:

  1. OpenGL 3.0 was not selecting NSOpenGLProfileVersionLegacy
  2. because of a Rust bug, match behavior was selecting the wrong profile (this should be address by Rewrite the pattern matching code in trans. rust-lang/rust#27050)

@paulrouget paulrouget mentioned this pull request Aug 10, 2015
Closed
@tomaka
Copy link
Contributor

tomaka commented Aug 10, 2015

While you're at it, I don't think requesting a core profile with a legacy version should return an error.

cc @fkaa @SSheldon

@paulrouget
Copy link
Contributor Author

What profile to use in his case? NSOpenGLProfileVersionLegacy?

@paulrouget
Copy link
Contributor Author

Switched to legacy for 1., 2., 3.0 and 3.1.

@tomaka
Copy link
Contributor

tomaka commented Aug 11, 2015

r+ for me. Leaving open for a day or two in case someone more familiar with OS/X has something to say.

tomaka added a commit that referenced this pull request Aug 13, 2015
@tomaka
Merge pull request #567 from paulrouget/opengl-profile-selection-fix
5c60456 
Fix OpenGL profile selection
@tomaka tomaka merged commit 5c60456 into rust-windowing:master Aug 13, 2015
@bors-servo bors-servo mentioned this pull request Aug 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulrouget @tomaka