-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An Error Type for Selector::parse
#95
Conversation
LGTM even though some readability improvements would be welcome |
I think it makes sense to implement Error for this type. |
I would really appreciate if this fork gets merged ASAP as I need these changes to continue working on a project |
Looking into this rn, will be back ASAP |
Only did code which I touched, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, here are some more changes
Forgot this is already a `String`
I might be adding different error types if needed, but for now the error type for
Selector::parse
'sResult
is now a custom type that is exported.This PR resolves #60
Improvements to the code are welcome