Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fallback file implementation on Linux/Android #475

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

josephlr
Copy link
Member

Fixes #289 for Linux. Depends on #471

Now when running cargo test on Linux, we see additional tests for the file-based implementation:

running 11 tests
test error::tests::test_size ... ok
test imp::fallback::fill_large ... ok
test imp::fallback::fill_zero ... ok
test tests::fill_large ... ok
test tests::fill_zero ... ok
test imp::fallback::multithreading ... ok
test tests::multithreading ... ok
test imp::fallback::fill_small ... ok
test tests::fill_small ... ok
test imp::fallback::fill_huge ... ok
test tests::fill_huge ... ok

@josephlr josephlr mentioned this pull request Jun 12, 2024
@josephlr josephlr force-pushed the test_fallback branch 4 times, most recently from 92cc8f6 to 37fd41b Compare June 19, 2024 10:27
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Copy link
Member Author

josephlr commented Jun 20, 2024

Closing to keep conversation in #471

Nevermind, this change should probably be review separately.

@josephlr josephlr closed this Jun 20, 2024
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For platforms that implement runtime fallback logic, all paths should be tested
1 participant