API: Add impl From<*> for sem::TyKind and correct some names of semantic types
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
added
C-enhancement
|
The semver-check in our CI only found the two expected enum variant renames, I guess this should be good to go :D Some to think about #141 |
Veetaha
reviewed
Nov 25, 2023
xFrednet
changed the title
From<*> for sem::TyKind and correct some names of semantic types
Veetaha
approved these changes
Nov 25, 2023
Merged
via the queue into
rust-marker:master
with commit Nov 25, 2023
e1dfde8
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds boilerplate code required for the implementation of #141. I've also changed all semantic type construction, to use the
TypedBuilderinstead of the oldnew()function.This PR also includes some changes, visible to API consumers, probably best summarized by the changelog entires:
sem::TyKindnow implementsFrom<*>for all semantic types.sem::TyKind::FnTy->sem::TyKind::Fnsem::TyKind::ClosureTy->sem::TyKind::ClosureThat's basically it. Some boring repetitive code changes, which will hopefully make it easier to expand semantic types in the future :D