Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T-compiler meeting agenda: add Zulip discussion links to MCPs and FCPs #1724

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

apiraino
Copy link
Contributor

MCPs and FCPs all have a corresponding Zulip chat link for discussion before being approved (or declined).

In order to facilitate reaching this discussion happening on Zulip, this patch retrieves the first comment of an MCP/FCP, parses the corresponding Zulip link and add it to the T-compiler agenda.

Example of how the list of MCP/FCP look before this patch:

  • Old MCPs (not seconded, take a look)
    • "Consistently use "region" terminology in later stages of the compiler" compiler-team#634 (last review activity: 3 months ago)

Example of how the list of MCP/FCP look after this patch:

  • Old MCPs (not seconded, take a look)
    • "Consistently use "region" terminology in later stages of the compiler" compiler-team#634 (Zulip) (last review activity: 3 months ago)

This idea was mentioned in a T-compiler meeting (on Zulip, of course).

Thanks for looking at this patch!

r? @spastorino

src/github.rs Show resolved Hide resolved
src/github.rs Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum merged commit b53466e into rust-lang:master Sep 29, 2023
2 checks passed
@apiraino apiraino deleted the add_zulip_links_to_mcp_fcp branch September 29, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants