Overview #633

mark-i-m · 2020-03-26T04:28:10Z

This is our draft so far. Feedback welcome! And thanks to all who contributed 🎉

cc @chrissimpkins @rust-lang/wg-learning

resolves #320

src/overview.md

mark-i-m

@Centril Thanks for the detailed review. I will return later to address more of your comments.

LeSeulArtichaut

Tried to add entry points

src/overview.md

Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>

includes feedback from matklad (lexer) and centril (parser)

mark-i-m · 2020-04-14T22:45:04Z

Ok, so as per our discussion in the meeting, we now have a final-ish draft to attempt to merge. Followup work and improvements should be noted on #674. For now, comments and commits on the PR should be limited to fixing incorrect statements.

spastorino · 2020-04-15T13:16:41Z

In my opinion this is already good enough.

chrissimpkins

Some minor edits. Take or leave. Nothing that should block a merge here. Looks great @rust-lang/wg-rustc-dev-guide!

src/overview.md

chrissimpkins · 2020-04-15T17:24:53Z

src/overview.md

+  tremendous amount of change constantly going on.
+- Compiler integration: a number of other tools need to use the compiler in
+  various ways (e.g. cargo, clippy, miri, RLS) that must be supported.
+- Compiler stability: the compiler should not crash or fail ungracefully on the


Suggested change

- Compiler stability: the compiler should not crash or fail ungracefully on the

- Stability: the compiler should not crash or fail ungracefully on the

src/overview.md

With some items added to rust-lang#674 Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>

src/overview.md

Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>

JohnTitor

Applied some minor nits. Okay, I'd say "go ahead"!

LeSeulArtichaut

This is looking great! I've got nothing more to say.

LeSeulArtichaut · 2020-04-18T15:40:36Z

src/overview.md

+  parser, HIR, etc)? - e.g., `cargo rustc -- -Zunpretty=hir-tree` allows you to
+  view HIR representation
+- What is the main source entry point for `X`?
+- Where do phases diverge for cross-compilation to machine  code across


There is a trailing space here 👀

Suggested change

- Where do phases diverge for cross-compilation to machine code across

- Where do phases diverge for cross-compilation to machine code across

I'll make a new PR for these

LeSeulArtichaut · 2020-04-18T15:41:35Z

src/overview.md

+
+# Unresolved Questions
+
+


There are two lines here, unlike the rest of the document.

Suggested change

mark-i-m · 2020-04-18T16:12:05Z

🎉 🎉 🎉

mark-i-m · 2020-04-18T16:12:37Z

Thanks to everyone who was involved!

Followups should go in #674

chrissimpkins mentioned this pull request Mar 26, 2020

New Post: rustc-dev-guide Overview rust-lang/blog.rust-lang.org#551

Merged

2 tasks

chrissimpkins reviewed Mar 28, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

src/overview.md Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

ebroto reviewed Mar 28, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

src/overview.md Outdated Show resolved Hide resolved

Centril reviewed Apr 2, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

mark-i-m commented Apr 2, 2020

View reviewed changes

mark-i-m force-pushed the overview branch from 69848f3 to 72d62b7 Compare April 2, 2020 19:27

This comment has been minimized.

Sign in to view

chrissimpkins mentioned this pull request Apr 3, 2020

Overview: Command line argument parsing, lexer #659

Closed

LeSeulArtichaut reviewed Apr 3, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

mark-i-m changed the title ~~Overview~~ [WIP] Overview Apr 3, 2020

mark-i-m commented Apr 4, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

mark-i-m commented Apr 4, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

mark-i-m commented Apr 4, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

bjorn3 reviewed Apr 4, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

bjorn3 reviewed Apr 4, 2020

View reviewed changes

src/overview.md Show resolved Hide resolved

bjorn3 reviewed Apr 4, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

bjorn3 reviewed Apr 4, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

chrissimpkins mentioned this pull request Apr 6, 2020

Overview updates: parser #669

Closed

mark-i-m commented Apr 8, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

spastorino reviewed Apr 13, 2020

View reviewed changes

src/overview.md Show resolved Hide resolved

spastorino reviewed Apr 13, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

spastorino reviewed Apr 14, 2020

View reviewed changes

src/overview.md Show resolved Hide resolved

spastorino reviewed Apr 14, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

spastorino reviewed Apr 14, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

chrissimpkins and others added 13 commits April 14, 2020 16:04

[overview.md] add parser entry point links

0db4271

add a para on interning and arenas

46e549b

add entry points for type check and type inference

8760fbc

Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>

some cleanup

bbc6129

correct entry points for codegen

ab95d00

[overview.md] add documentation of lexer support for Unicode encoding

aa1184d

update mono entry points

4cf7d02

minor wording change on bootstrapping

d8a3c89

add intrinsics to glossary

3780344

fix links

74f5f88

[overview.md] add initial parser documentation

2b587b0

[overview.md] add lexer updates, parser updates

d023ac7

includes feedback from matklad (lexer) and centril (parser)

line length

ce3ff58

mark-i-m changed the title ~~[WIP] Overview~~ Overview Apr 14, 2020

chrissimpkins previously approved these changes Apr 15, 2020

View reviewed changes

Remove various todos

e5f427d

With some items added to rust-lang#674 Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>

mark-i-m dismissed stale reviews from chrissimpkins via e5f427d April 18, 2020 02:14

add link to intrinsic

83105be

JohnTitor reviewed Apr 18, 2020

View reviewed changes

src/overview.md Outdated Show resolved Hide resolved

Apply suggestions from code review

2d53282

Co-Authored-By: Chris Simpkins <git.simpkins@gmail.com>

JohnTitor approved these changes Apr 18, 2020

View reviewed changes

chrissimpkins approved these changes Apr 18, 2020

View reviewed changes

LeSeulArtichaut approved these changes Apr 18, 2020

View reviewed changes

mark-i-m merged commit e927db9 into rust-lang:master Apr 18, 2020

mark-i-m deleted the overview branch April 18, 2020 16:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overview #633

Overview #633

mark-i-m commented Mar 26, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mark-i-m left a comment

This comment has been minimized.

LeSeulArtichaut left a comment

This comment has been minimized.

This comment has been minimized.

mark-i-m commented Apr 14, 2020

spastorino commented Apr 15, 2020 •

edited

Loading

chrissimpkins left a comment

chrissimpkins Apr 15, 2020

JohnTitor left a comment

LeSeulArtichaut left a comment

LeSeulArtichaut Apr 18, 2020

mark-i-m Apr 18, 2020

LeSeulArtichaut Apr 18, 2020

mark-i-m commented Apr 18, 2020

mark-i-m commented Apr 18, 2020

	- Compiler stability: the compiler should not crash or fail ungracefully on the
	- Stability: the compiler should not crash or fail ungracefully on the

	- Where do phases diverge for cross-compilation to machine code across
	- Where do phases diverge for cross-compilation to machine code across

Overview #633

Overview #633

Conversation

mark-i-m commented Mar 26, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mark-i-m left a comment

Choose a reason for hiding this comment

This comment has been minimized.

LeSeulArtichaut left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

mark-i-m commented Apr 14, 2020

spastorino commented Apr 15, 2020 • edited Loading

chrissimpkins left a comment

Choose a reason for hiding this comment

chrissimpkins Apr 15, 2020

Choose a reason for hiding this comment

JohnTitor left a comment

Choose a reason for hiding this comment

LeSeulArtichaut left a comment

Choose a reason for hiding this comment

LeSeulArtichaut Apr 18, 2020

Choose a reason for hiding this comment

mark-i-m Apr 18, 2020

Choose a reason for hiding this comment

LeSeulArtichaut Apr 18, 2020

Choose a reason for hiding this comment

mark-i-m commented Apr 18, 2020

mark-i-m commented Apr 18, 2020

mark-i-m commented Mar 26, 2020 •

edited

Loading

spastorino commented Apr 15, 2020 •

edited

Loading