Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pretty printing of valtrees for references #98643

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Improve pretty printing of valtrees for references #98643

merged 4 commits into from
Jun 29, 2022

Conversation

voidc
Copy link
Contributor

@voidc voidc commented Jun 28, 2022

This implements the changes outlined in #66451 (comment).

r? @lcnr
Fixes #66451

@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022
lcnr
lcnr reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some possible further improvements to destructure_const, then r=me

thanks ❤️

compiler/rustc_ty_utils/src/consts.rs Outdated Show resolved Hide resolved
compiler/rustc_ty_utils/src/consts.rs Outdated Show resolved Hide resolved
compiler/rustc_ty_utils/src/consts.rs Outdated Show resolved Hide resolved
compiler/rustc_ty_utils/src/consts.rs Outdated Show resolved Hide resolved
@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

@bors delegate+

@bors
Copy link
Contributor

bors commented Jun 29, 2022

✌️ @voidc can now approve this pull request

@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022 •
edited
Loading

with @bors delegate+ you can do @bors r=<name-of-reviewer> yourself, without having to wait for the reviewer to look at your last changes.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit d048b15 has been approved by ```

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

gdi bors xd

@lcnr
Copy link
Contributor

lcnr commented Jun 29, 2022

@bors r-
@bors r+

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2022
@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit d048b15 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2022
@bors
Auto merge of rust-lang#98680 - matthiaskrgr:rollup-1bkrrn9, r=matthi…
ddcbba0 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#98434 (Ensure that `static_crt` is set in the bootstrapper whenever using `cc-rs` to get a compiler command line.)
 - rust-lang#98636 (Triagebot: Fix mentions word wrapping.)
 - rust-lang#98642 (Fix rust-lang#98260)
 - rust-lang#98643 (Improve pretty printing of valtrees for references)
 - rust-lang#98646 (rustdoc: fix bugs in main.js popover help and settings)
 - rust-lang#98647 (Update cargo)
 - rust-lang#98652 (`alloc`: clean and ensure `no_global_oom_handling`  builds are warning-free)
 - rust-lang#98660 (Unbreak stage1 tests via ignore-stage1 in `proc-macro/invalid-punct-ident-1.rs`.)
 - rust-lang#98665 (Use verbose help for deprecation suggestion)
 - rust-lang#98668 (Avoid some `&str` to `String` conversions with `MultiSpan::push_span_label`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 921e311 into rust-lang:master Jun 29, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Replace Debug representation in const value pretty print
5 participants
@voidc @rustbot @lcnr @bors @rust-highfive