Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: correct path to type alias methods #96887

Merged
merged 3 commits into from
May 11, 2022
Merged

rustdoc: correct path to type alias methods #96887

merged 3 commits into from
May 11, 2022

Conversation

notriddle
Copy link
Contributor

Fixes #83991

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive
Copy link
Collaborator

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@notriddle
rustdoc: clean up method path index
6257bd2 
This removes a special case that doesn't seem to do anything
any more.
@jsha
Copy link
Contributor

jsha commented May 10, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2022

📌 Commit 6257bd2 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#96887 - notriddle:notriddle/as-raw-fd, r=jsha
7cdb374 
rustdoc: correct path to type alias methods

Fixes rust-lang#83991
@matthiaskrgr matthiaskrgr mentioned this pull request May 10, 2022
Closed
@notriddle
Copy link
Contributor Author

@bors r-

Failed in rollup.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2022
@notriddle
Ignore order
9dc5ac8 
This isn't an ordering test really, anyway...
@notriddle
Copy link
Contributor Author

r? @jsha

@jsha
Copy link
Contributor

jsha commented May 10, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 10, 2022

📌 Commit 9dc5ac8 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2022
@JohnTitor JohnTitor mentioned this pull request May 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2022
@bors
Auto merge of rust-lang#96931 - JohnTitor:rollup-3um8o4j, r=JohnTitor
ee6eaab 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#96543 (Remove hacks in `make_token_stream`.)
 - rust-lang#96887 (rustdoc: correct path to type alias methods)
 - rust-lang#96896 (Add regression test for rust-lang#68408)
 - rust-lang#96900 (Fix js error)
 - rust-lang#96903 (Use lifetimes on type-alias-impl-trait used in function signatures to infer output type lifetimes)
 - rust-lang#96916 (simplify length count)
 - rust-lang#96925 (Fix issue rust-lang#95151)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed9faee into rust-lang:master May 11, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 11, 2022
@notriddle notriddle deleted the notriddle/as-raw-fd branch May 11, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha left review comments

Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

rustdoc links to type aliases that don't exist in search results
5 participants
@notriddle @rust-highfive @jsha @bors @rustbot