linker: Implicitly link native libs as whole-archive in some more cases #95606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
petrochenkov
commented
Apr 2, 2022
| if whole_archive == Some(true) | ||
| || (whole_archive == None && default_to_whole_archive(sess, crate_type, cmd)) | ||
| // Backward compatibility case: this can be a rlib (so `+whole-archive` cannot | ||
| // be added explicitly if necessary, see the error in `fn link_rlib`) compiled | ||
| // as an executable due to `--test`. Use whole-archive implicitly, like before |
There was a problem hiding this comment.
Unfortunately we cannot determine whether it would be a rlib or not if --test weren't passed, because the rlib-ness is typically specified by cargo.
#95561, for example still looks like an executable if we ignore --test in fn collect_crate_types.
|
Thanks for jumping on this so quickly! @bors r+ p=1 Fixing nightly regression |
|
📌 Commit a169d33 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ac4b345): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert changes from #93901 to address regressions like #95561.
Fixes #95561
r? @wesleywiser