Add Attribute::meta_kind #92294

Kobzol · 2021-12-26T16:04:33Z

The AttrItem::meta function is being called on a lot of places, however almost always the caller is only interested in the kind of the result MetaItem. Before, the path had to be cloned in order to get the kind, now it does not have to be.

There is a larger related "problem". In a lot of places, something wants to know contents of attributes. This is accessed through Attribute::meta_item_list, which calls AttrItem::meta (now AttrItem::meta_kind), among other methods. When this function is called, the meta item list has to be recreated from scratch. Everytime something asks a simple question (like is this item/list of attributes #[doc(hidden)]?), the tokens of the attribute(s) are cloned, parsed and the results are allocated on the heap. That seems really unnecessary. What would be the best way to cache this? Turn meta_item_list into a query perhaps? Related PR: #92227

r? rust-lang/rustdoc

Aaron1011 · 2021-12-26T17:59:02Z

@bors try @rust-timer queue

rust-timer · 2021-12-26T17:59:03Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-12-26T17:59:09Z

⌛ Trying commit 047275a with merge e2cda9a39cee49d9e3085509133f04ad8e34ca73...

bors · 2021-12-26T19:24:41Z

☀️ Try build successful - checks-actions
Build commit: e2cda9a39cee49d9e3085509133f04ad8e34ca73 (e2cda9a39cee49d9e3085509133f04ad8e34ca73)

rust-timer · 2021-12-26T19:24:43Z

Queued e2cda9a39cee49d9e3085509133f04ad8e34ca73 with parent f8abed9, future comparison URL.

rust-timer · 2021-12-26T20:53:59Z

Finished benchmarking commit (e2cda9a39cee49d9e3085509133f04ad8e34ca73): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

Small improvement in instruction counts (up to -0.8% on full builds of unify-linearly)
Moderate regression in instruction counts (up to 1.1% on incr-unchanged builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

jyn514 · 2021-12-27T01:05:07Z

r? @GuillaumeGomez

GuillaumeGomez · 2021-12-27T11:03:37Z

There is a larger related "problem". In a lot of places, something wants to know contents of attributes. This is accessed through Attribute::meta_item_list, which calls AttrItem::meta (now AttrItem::meta_kind), among other methods. When this function is called, the meta item list has to be recreated from scratch. Everytime something asks a simple question (like is this item/list of attributes #[doc(hidden)]?), the tokens of the attribute(s) are cloned, parsed and the results are allocated on the heap. That seems really unnecessary. What would be the best way to cache this? Turn meta_item_list into a query perhaps?

Adding a query would be the right move as you suggested I think.

Thanks for this improvement!

@bors: r+

bors · 2021-12-27T11:03:38Z

📌 Commit 047275a has been approved by GuillaumeGomez

bors · 2021-12-27T12:10:29Z

⌛ Testing commit 047275a with merge 588e00bd33f4921e2c26eddd0bf853a1ddeb5969...

bors · 2021-12-27T12:47:05Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-12-27T12:52:46Z

The job dist-various-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [run-make] run-make/emit-shared-files ... ok
test [run-make] run-make/rustdoc-scrape-examples-ordering ... ok
test [run-make] run-make/rustdoc-scrape-examples-multiple ... ok
test [run-make] run-make/thumb-none-qemu ... ok
test [run-make] run-make/thumb-none-cortex-m has been running for over 60 seconds
Some tests failed in compiletest suite=run-make mode=run-make host=x86_64-unknown-linux-gnu target=thumbv7em-none-eabihf

failures:


---- [run-make] run-make/thumb-none-cortex-m stdout ----
error: make failed
status: exit status: 2
command: "make"
stdout:
stdout:
------------------------------------------
env
SRC=/checkout
CC_armv7a_none_eabihf=arm-none-eabi-gcc
DOC_RUST_LANG_ORG_CHANNEL=https://doc.rust-lang.org/nightly
MAIL=/var/mail/user
LLVM_FILECHECK=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck
CFLAGS_arm_unknown_linux_musleabihf=-march=armv6 -marm -mfpu=vfp
RUST_BUILD_STAGE=stage2-thumbv7em-none-eabihf
SCRIPT=python3 ../x.py --stage 2 test --host= --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make &&       python3 ../x.py dist --host= --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,mips-unknown-linux-musl,mipsel-unknown-linux-musl,mips64-unknown-linux-muslabi64,mips64el-unknown-linux-muslabi64,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-none,aarch64-unknown-none-softfloat,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,thumbv8m.base-none-eabi,thumbv8m.main-none-eabi,thumbv8m.main-none-eabihf,riscv32i-unknown-none-elf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,riscv64imac-unknown-none-elf,riscv64gc-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf,thumbv7neon-unknown-linux-gnueabihf,armv7a-none-eabi
CI=true
CI=true
RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te       --musl-root-arm=/musl-arm       --musl-root-armhf=/musl-armhf       --musl-root-armv7hf=/musl-armv7hf       --musl-root-mips=/musl-mips       --musl-root-mipsel=/musl-mipsel       --musl-root-mips64=/musl-mips64       --musl-root-mips64el=/musl-mips64el       --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --dist-compression-formats=xz --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --debuginfo-level-std=1 --enable-missing-tools
CC_mips64_unknown_linux_muslabi64=mips64-linux-gnuabi64-gcc
HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
HOSTNAME=849f88eb7388
TARGET=thumbv7em-none-eabihf
---
CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
BOOTSTRAP_PARENT_ID=1963
CFLAGS_armv7a_none_eabi=-march=armv7-a
RUSTC_BOOTSTRAP=1
LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
_=/usr/bin/sh
CXX_thumbv7neon_unknown_linux_gnueabihf=arm-linux-gnueabihf-g++
LLVM_BIN_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin
LLVM_BIN_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin
AR=arm-none-eabi-ar
CC_mips64el_unknown_linux_muslabi64=mips64el-linux-gnuabi64-gcc
TERM=xterm
SCCACHE_BUCKET=rust-lang-ci-sccache2
BASE_COMMIT=f8abed9ed48bace6be0087bcd44ed534e239b8d8
CFLAGS_armv7_unknown_linux_musleabihf=-march=armv7-a
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv7em-none-eabihf/lib
LLVM_COMPONENTS=aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray
RUSTFLAGS=--cap-lints=warn
MAKELEVEL=1
MIRRORS_BASE=https://ci-mirrors.rust-lang.org/rustc
CC_thumbv7neon_unknown_linux_gnueabihf=arm-linux-gnueabihf-gcc
CFLAGS_armv7a_none_eabihf=-march=armv7-a+vfpv3
CFLAGS_armv7a_none_eabihf=-march=armv7-a+vfpv3
TOOLSTATE_PUBLISH=1
__COMPAT_LAYER=RunAsInvoker
STAGING_DIR=/tmp
COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS=1
COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS=1
RUSTDOC=LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc' -L /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv7em-none-eabihf/lib -Clinker='arm-none-eabi-gcc'
RUST_TEST_THREADS=16
CFLAGS_armv5te_unknown_linux_musleabi=-march=armv5te -marm -mfloat-abi=soft
DEPLOY=1
DEPLOY=1
CXX=arm-none-eabi-g++ -ffunction-sections -fdata-sections -mthumb -mfloat-abi=hard -march=armv7e-m -mfpu=fpv4-sp-d16
AWS_ACCESS_KEY_ID=AKIA46X5W6CZI5DHEBFL
AWS_SECRET_ACCESS_KEY=***
TOOLSTATE_REPO_ACCESS_TOKEN=***
BOOTSTRAP_CONFIG=config.toml
BOOTSTRAP_CONFIG=config.toml
CC_aarch64_unknown_none_softfloat=aarch64-none-elf-gcc
CFLAGS_arm_unknown_linux_musleabi=-march=armv6 -marm
GITHUB_REF=refs/heads/auto
BOOTSTRAP_CARGO=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo
***
CFLAGS_aarch64_unknown_none=-mstrict-align
CFLAGS_aarch64_unknown_none=-mstrict-align
BOOTSTRAP_PYTHON=/usr/bin/python3
CARGO_HOME=/cargo
RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
CC=arm-none-eabi-gcc -ffunction-sections -fdata-sections -mthumb -mfloat-abi=hard -march=armv7e-m -mfpu=fpv4-sp-d16
CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
CI_JOB_NAME=dist-various-1
RUSTC_LINKER=arm-none-eabi-gcc
mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && rm -rf cortex-m
cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && bash -x /checkout/src/test/run-make/thumb-none-cortex-m/../git_clone_sha1.sh cortex-m https://github.com/rust-embedded/cortex-m a448e9156e2cb1e556e5441fd65426952ef4b927 

------------------------------------------
stderr:
------------------------------------------
------------------------------------------
+ PROJECT_NAME=cortex-m
+ URL=https://github.com/rust-embedded/cortex-m
+ SHA1=a448e9156e2cb1e556e5441fd65426952ef4b927
+ git clone https://github.com/rust-embedded/cortex-m cortex-m
Cloning into 'cortex-m'...
fatal: unable to access 'https://github.com/rust-embedded/cortex-m/': GnuTLS recv error (-54): Error in the pull function.
+ err_exit
+ echo ERROR:
+ exit 1
make: *** [Makefile:34: all] Error 1
------------------------------------------




failures:
    [run-make] run-make/thumb-none-cortex-m

test result: FAILED. 22 passed; 1 failed; 25 ignored; 0 measured; 0 filtered out; finished in 336.20s



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv7em-none-eabihf/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv7em-none-eabihf" "--suite" "run-make" "--mode" "run-make" "--target" "thumbv7em-none-eabihf" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/thumbv7em-none-eabihf/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--llvm-version" "13.0.0-rust-1.59.0-nightly" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray" "--llvm-bin-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin" "--cc" "arm-none-eabi-gcc" "--cxx" "arm-none-eabi-g++" "--cflags" "-ffunction-sections -fdata-sections -mthumb -mfloat-abi=hard -march=armv7e-m -mfpu=fpv4-sp-d16" "--ar" "arm-none-eabi-ar" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:23:39

Aaron1011 · 2021-12-27T15:04:02Z

@bors retry

jyn514 · 2021-12-28T14:31:17Z

Everytime something asks a simple question (like is this item/list of attributes #[doc(hidden)]?), the tokens of the attribute(s) are cloned, parsed and the results are allocated on the heap.

Not doing this was the reason using is_doc_hidden was a speedup, right? Can we use that same logic for other things besides doc(hidden)? Then we don't have to involve the query system at all and it's less complicated.

Kobzol · 2021-12-28T17:06:24Z

@jyn514 Actually, the improvements came from something else (faster iteration, see #92353).

Each time is_doc_hidden is called, it has to clone and re-parse its token stream and then allocate some stuff on the heap, for each attribute, because it calls meta_item_list.

bors · 2021-12-29T08:57:46Z

⌛ Testing commit 047275a with merge da30006ba96358bbfd605eda9e26bd83b03979db...

bors · 2021-12-29T09:00:22Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-12-29T09:03:26Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

matthiaskrgr · 2021-12-29T10:01:30Z

@bors retry network failure

   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: ci-mirrors.rust-lang.org

bors · 2021-12-29T15:19:33Z

⌛ Testing commit 047275a with merge db21c41f6cdbd2c07e8b3bc06e2acb447ffcba35...

rust-log-analyzer · 2021-12-29T16:06:46Z

The job x86_64-msvc-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

9 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
10 


The actual run.stderr differed from the expected run.stderr.
Actual run.stderr saved to D:\a\rust\rust\build\x86_64-pc-windows-msvc\test\ui\panics\panic-short-backtrace-windows-x86_64\panic-short-backtrace-windows-x86_64.run.stderr
error: 1 errors occurred comparing run output.
status: exit code: 101
status: exit code: 101
command: PATH="D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\lib\rustlib\x86_64-pc-windows-msvc\lib;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\msys2\mingw64\bin;C:\hostedtoolcache\windows\Python\3.10.1\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.1\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.3\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.1\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.1.2\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.15.15\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.312-7\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.4\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui\\panics\\panic-short-backtrace-windows-x86_64\\a.exe"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
thread 'main' panicked at 'd was called', D:\a\rust\rust\src/test\ui\panics\panic-short-backtrace-windows-x86_64.rs:48:5
   0: std::panicking::begin_panic
   1: d
   2: c
   3: b
---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc


command did not execute successfully: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin" "--run-lib-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "--rustc-path" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin\\rustc.exe" "--src-base" "D:\\a\\rust\\rust\\src/test\\ui" "--build-base" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui" "--stage-id" "stage2-x86_64-pc-windows-msvc" "--suite" "ui" "--mode" "ui" "--target" "x86_64-pc-windows-msvc" "--host" "x86_64-pc-windows-msvc" "--llvm-filecheck" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--npm" "C:\\Program Files\\nodejs\\npm" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "--docck-python" "C:\\hostedtoolcache\\windows\\Python\\3.10.1\\x64\\python3.exe" "--lldb-python" "C:\\hostedtoolcache\\windows\\Python\\3.10.1\\x64\\python3.exe" "--gdb" "C:\\msys64\\usr\\bin\\gdb" "--llvm-version" "13.0.0-rust-1.59.0-nightly" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:42:20
Build completed unsuccessfully in 0:42:20
make: *** [Makefile:74: ci-subset-2] Error 1

bors · 2021-12-29T16:07:17Z

💔 Test failed - checks-actions

matthiaskrgr · 2021-12-31T09:11:44Z

@bors retry #92000

bors · 2022-01-01T02:03:26Z

⌛ Testing commit 047275a with merge c9cf9c6...

bors · 2022-01-01T05:21:17Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing c9cf9c6 to master...

rust-timer · 2022-01-01T06:52:07Z

Finished benchmarking commit (c9cf9c6): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Add Attribute::meta_kind

047275a

rust-highfive assigned ollie27 Dec 26, 2021

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 26, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 26, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 26, 2021

rust-highfive assigned GuillaumeGomez and unassigned ollie27 Dec 27, 2021

GuillaumeGomez approved these changes Dec 27, 2021

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021

bors mentioned this pull request Dec 27, 2021

resolve: Minor miscellaneous cleanups from #89059 #92161

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 27, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2022

bors merged commit c9cf9c6 into rust-lang:master Jan 1, 2022

rustbot added this to the 1.59.0 milestone Jan 1, 2022

rustbot removed the perf-regression Performance regression. label Jan 1, 2022

Kobzol deleted the rustdoc-meta-kind branch January 3, 2022 09:23

pnkfelix mentioned this pull request Jan 4, 2022

PR 92294 was flagged as "probably changed"; why not "Improvement" ? rust-lang/rustc-perf#1135

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Attribute::meta_kind #92294

Add Attribute::meta_kind #92294

Kobzol commented Dec 26, 2021 •

edited

Loading

Aaron1011 commented Dec 26, 2021

rust-timer commented Dec 26, 2021

bors commented Dec 26, 2021

bors commented Dec 26, 2021

rust-timer commented Dec 26, 2021

rust-timer commented Dec 26, 2021

jyn514 commented Dec 27, 2021

GuillaumeGomez commented Dec 27, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

Aaron1011 commented Dec 27, 2021

jyn514 commented Dec 28, 2021

Kobzol commented Dec 28, 2021

bors commented Dec 29, 2021

bors commented Dec 29, 2021

rust-log-analyzer commented Dec 29, 2021

matthiaskrgr commented Dec 29, 2021

bors commented Dec 29, 2021

rust-log-analyzer commented Dec 29, 2021

bors commented Dec 29, 2021

matthiaskrgr commented Dec 31, 2021

bors commented Jan 1, 2022

bors commented Jan 1, 2022

rust-timer commented Jan 1, 2022

Add Attribute::meta_kind #92294

Add Attribute::meta_kind #92294

Conversation

Kobzol commented Dec 26, 2021 • edited Loading

Aaron1011 commented Dec 26, 2021

rust-timer commented Dec 26, 2021

bors commented Dec 26, 2021

bors commented Dec 26, 2021

rust-timer commented Dec 26, 2021

rust-timer commented Dec 26, 2021

jyn514 commented Dec 27, 2021

GuillaumeGomez commented Dec 27, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

bors commented Dec 27, 2021

rust-log-analyzer commented Dec 27, 2021

Aaron1011 commented Dec 27, 2021

jyn514 commented Dec 28, 2021

Kobzol commented Dec 28, 2021

bors commented Dec 29, 2021

bors commented Dec 29, 2021

rust-log-analyzer commented Dec 29, 2021

matthiaskrgr commented Dec 29, 2021

bors commented Dec 29, 2021

rust-log-analyzer commented Dec 29, 2021

bors commented Dec 29, 2021

matthiaskrgr commented Dec 31, 2021

bors commented Jan 1, 2022

bors commented Jan 1, 2022

rust-timer commented Jan 1, 2022

Kobzol commented Dec 26, 2021 •

edited

Loading