Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: avoid many Symbol to String conversions. #91948

Merged
merged 7 commits into from
Jan 15, 2022
Merged

rustdoc: avoid many Symbol to String conversions. #91948

merged 7 commits into from
Jan 15, 2022

Commits on Jan 14, 2022

  1. rustdoc: avoid many Symbol to String conversions. 

    Particularly when constructing file paths and fully qualified paths.
This avoids a lot of allocations, speeding things up on almost all
examples.
    @nnethercote @camelid
    nnethercote authored and camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    10b1c9a View commit details
    Browse the repository at this point in the history

  2. rustdoc: remove many unnecessary .as_ref() calls.

    @nnethercote @camelid
    nnethercote authored and camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    1e4637c View commit details
    Browse the repository at this point in the history

  3. rustdoc: remove some unnecessary sigils.

    @nnethercote @camelid
    nnethercote authored and camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    6b19cf9 View commit details
    Browse the repository at this point in the history

  4. Use UrlPartsBuilder and remove join_with_slash

    @camelid
    camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    53f1bed View commit details
    Browse the repository at this point in the history

  5. Estimate path length instead of hardcoding 64 bytes

    @camelid
    camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8f59eb6 View commit details
    Browse the repository at this point in the history

  6. Make AVG_PART_LENGTH a power of 2 

    I seem to recall that in general, it's best to request an allocation
with a size that's a power of 2. The low estimate of 5 was probably a
little too low as well.
    @camelid
    camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cef250d View commit details
    Browse the repository at this point in the history

  7. Document and test UrlPartsBuilder::push_fmt

    @camelid
    camelid committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    c7147e4 View commit details
    Browse the repository at this point in the history