Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPERIMENT] Don't monomorphize things that are unused due to if <T as Trait>::CONST #91222

Closed
wants to merge 4 commits into from
Closed

[EXPERIMENT] Don't monomorphize things that are unused due to if <T as Trait>::CONST #91222

wants to merge 4 commits into from

Commits on Nov 25, 2021

  1. [EXPERIMENT] Don't monomorphize things that are unused due to if CONST 

    MIR optimizations have long meant that we do this for concrete constants, but with this it also applies for things like `<T as TrustedRandomAccess>::MAY_HAVE_SIDE_EFFECT`.
    @scottmcm
    scottmcm committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    568fe20 View commit details
    Browse the repository at this point in the history

  2. extract const guard to trait associated const for optimization experi… 

    …ments
    @the8472
    the8472 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    6b99f05 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3 from the8472/vec-spec-assoc-const 

    extract const guard to trait associated const for optimization experiment
    @scottmcm
    scottmcm committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    10acbf8 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. Skip those blocks in codegen too, to avoid the linker errors 

    And hey, maybe even be faster because it means less IR emitted.
    @scottmcm
    scottmcm committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    b5d6de2 View commit details
    Browse the repository at this point in the history