Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf-check] Revert "Rollup merge of #88789 - the8472:rm-zip-bound, r=JohnTitor" #90381

Closed
wants to merge 1 commit into from
Closed

[perf-check] Revert "Rollup merge of #88789 - the8472:rm-zip-bound, r=JohnTitor" #90381

wants to merge 1 commit into from

Conversation

JohnTitor
Copy link
Member

This reverts commit 84fe598, reversing
changes made to 71fcb72.

r? @ghost cc #90067 (comment)

@JohnTitor
Revert "Rollup merge of rust-lang#88789 - the8472:rm-zip-bound, r=Joh…
63b4faa 
…nTitor"

This reverts commit 84fe598, reversing
changes made to 71fcb72.
@JohnTitor
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2021
@bors
Copy link
Contributor

bors commented Oct 28, 2021

⌛ Trying commit 63b4faa with merge d15f91eebbf502f315748c021e2bd8223aed77c1...

@bors
Copy link
Contributor

bors commented Oct 28, 2021

☀️ Try build successful - checks-actions
Build commit: d15f91eebbf502f315748c021e2bd8223aed77c1 (d15f91eebbf502f315748c021e2bd8223aed77c1)

@rust-timer
Copy link
Collaborator

Queued d15f91eebbf502f315748c021e2bd8223aed77c1 with parent f2707fe, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d15f91eebbf502f315748c021e2bd8223aed77c1): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 28, 2021
@JohnTitor
Copy link
Member Author

Seems this isn't perf-sensitive, closing but cc @Mark-Simulacrum just in case.

@JohnTitor JohnTitor closed this Oct 30, 2021
@JohnTitor JohnTitor deleted the revert-88789 branch October 30, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnTitor @rust-timer @bors @rustbot