Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch order of terms to prevent overflow #89823

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Switch order of terms to prevent overflow #89823

merged 1 commit into from
Oct 14, 2021

Conversation

jackh726
Copy link
Member

Fixes #89639

r? @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Oct 14, 2021

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 14, 2021

📌 Commit 9855e7d has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned pnkfelix Oct 14, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#89823 - jackh726:project-overflow, r=oli-obk
ecc351d 
Switch order of terms to prevent overflow

Fixes rust-lang#89639

r? `@pnkfelix`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2021
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2021
Merged
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 14, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2021
@bors
Auto merge of rust-lang#89882 - matthiaskrgr:rollup-1dh7pz8, r=matthi…
e1e9319 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#89390 (Fix incorrect Box::pin suggestion)
 - rust-lang#89433 (Fix ctrl-c causing reads of stdin to return empty on Windows.)
 - rust-lang#89823 (Switch order of terms to prevent overflow)
 - rust-lang#89865 (Allow static linking LLVM with ThinLTO)
 - rust-lang#89873 (Add missing word to `FromStr` trait documentation)
 - rust-lang#89878 (Fix missing remaining compiler specific cfg information)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 29081f9 into rust-lang:master Oct 14, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 14, 2021
@jackh726 jackh726 deleted the project-overflow branch October 14, 2021 19:28
@jackh726 jackh726 restored the project-overflow branch March 12, 2022 18:26
@jackh726 jackh726 deleted the project-overflow branch March 12, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

ui/deriving/issue-89188-gat-hrtb.rs test fails with debug assertions enabled
7 participants
@jackh726 @oli-obk @bors @pnkfelix @apiraino @rust-highfive @rustbot