Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially stabilize array_methods #88353

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Partially stabilize array_methods #88353

merged 1 commit into from
Oct 4, 2021

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Aug 26, 2021

This stabilizes <[T; N]>::as_slice and <[T; N]>::as_mut_slice, which is forms part of the array_methods feature: #76118.

This also makes <[T; N]>::as_slice const due to its trivial nature.

@jhpratt
Partially stabilize array_methods
905c2ba 
This also makes `<[T; N]>::as_slice` const due to its trivial nature.
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2021
@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 26, 2021
@jhpratt jhpratt mentioned this pull request Aug 26, 2021
Closed
5 tasks
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 26, 2021
@joshtriplett
Copy link
Member

Since this is a partial stabilization, I'm going to do the FCP in this issue rather than the tracking issue.

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Aug 26, 2021 •
edited by m-ou-se
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 26, 2021
@rfcbot
Copy link

rfcbot commented Aug 31, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@Luro02 Luro02 mentioned this pull request Sep 4, 2021
Open
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 10, 2021
@rfcbot
Copy link

rfcbot commented Sep 10, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@jhpratt
Copy link
Member Author

jhpratt commented Sep 13, 2021

Ping @joshtriplett FCP completed a few days ago. No rush to merge as we've a number of weeks to the next beta fork, but just want to bring this to your attention.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 16, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2021
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 4, 2021

📌 Commit 905c2ba has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 4, 2021
@Manishearth
Rollup merge of rust-lang#88353 - jhpratt:stabilize-array-as-ref, r=j…
cb835c8 
…oshtriplett

Partially stabilize `array_methods`

This stabilizes `<[T; N]>::as_slice` and `<[T; N]>::as_mut_slice`, which is forms part of the `array_methods` feature: rust-lang#76118.

This also makes `<[T; N]>::as_slice` const due to its trivial nature.
This was referenced Oct 4, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2021
@bors
Auto merge of rust-lang#89512 - Manishearth:rollup-meh9x7r, r=Manishe…
44593ae 
…arth

Rollup of 14 pull requests

Successful merges:

 - rust-lang#86434 (Add `Ipv6Addr::is_benchmarking`)
 - rust-lang#86828 (const fn for option copied, take & replace)
 - rust-lang#87679 (BTree: refine some comments)
 - rust-lang#87910 (Mark unsafe methods NonZero*::unchecked_(add|mul) as const.)
 - rust-lang#88286 (Remove unnecessary unsafe block in `process_unix`)
 - rust-lang#88305 (Manual Debug for Unix ExitCode ExitStatus ExitStatusError)
 - rust-lang#88353 (Partially stabilize `array_methods`)
 - rust-lang#88370 (Add missing `# Panics` section to `Vec` method)
 - rust-lang#88481 (Remove some feature gates)
 - rust-lang#89138 (Fix link in Ipv6Addr::to_ipv4 docs)
 - rust-lang#89401 (Add truncate note to Vec::resize)
 - rust-lang#89467 (Fix typos in rustdoc/lints)
 - rust-lang#89472 (Only register `WSACleanup` if `WSAStartup` is actually ever called)
 - rust-lang#89505 (Add regression test for spurious const error with NLL)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 70d82e0 into rust-lang:master Oct 4, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 4, 2021
@jhpratt jhpratt deleted the stabilize-array-as-ref branch October 5, 2021 03:14
@jplatte jplatte mentioned this pull request Oct 5, 2021
Open
65 tasks
@iddm
Copy link

iddm commented Oct 12, 2021

Sorry for chiming in, but is there a work-around as of now, to create a slice from an array? I need to work with [u8; 4] as with &[u8].

@jplatte
Copy link
Contributor

jplatte commented Oct 12, 2021

@vityafx yes, use &array[..].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.