-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ICE on type error recovery #86764
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
trait Foo<T, T = T> {} | ||
//~^ ERROR the name `T` is already used for a generic parameter in this item's generic parameters | ||
|
||
fn eq<A, B>() { | ||
eq::<dyn, Foo> | ||
//~^ ERROR cannot find type `dyn` in this scope | ||
//~| ERROR missing generics for trait `Foo` | ||
//~| WARN trait objects without an explicit `dyn` are deprecated | ||
//~| WARN this is accepted in the current edition | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
error[E0403]: the name `T` is already used for a generic parameter in this item's generic parameters | ||
--> $DIR/issue-86756.rs:1:14 | ||
| | ||
LL | trait Foo<T, T = T> {} | ||
| - ^ already used | ||
| | | ||
| first use of `T` | ||
|
||
error[E0412]: cannot find type `dyn` in this scope | ||
--> $DIR/issue-86756.rs:5:10 | ||
| | ||
LL | fn eq<A, B>() { | ||
| - help: you might be missing a type parameter: `, dyn` | ||
LL | eq::<dyn, Foo> | ||
| ^^^ not found in this scope | ||
|
||
warning: trait objects without an explicit `dyn` are deprecated | ||
--> $DIR/issue-86756.rs:5:15 | ||
| | ||
LL | eq::<dyn, Foo> | ||
| ^^^ help: use `dyn`: `dyn Foo` | ||
| | ||
= note: `#[warn(bare_trait_objects)]` on by default | ||
= warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! | ||
= note: for more information, see issue #80165 <https://github.com/rust-lang/rust/issues/80165> | ||
|
||
error[E0107]: missing generics for trait `Foo` | ||
--> $DIR/issue-86756.rs:5:15 | ||
| | ||
LL | eq::<dyn, Foo> | ||
| ^^^ expected at least 1 generic argument | ||
| | ||
note: trait defined here, with at least 1 generic parameter: `T` | ||
--> $DIR/issue-86756.rs:1:7 | ||
| | ||
LL | trait Foo<T, T = T> {} | ||
| ^^^ - | ||
help: add missing generic argument | ||
| | ||
LL | eq::<dyn, Foo<T>> | ||
| ^^^^^^ | ||
|
||
error: aborting due to 3 previous errors; 1 warning emitted | ||
|
||
Some errors have detailed explanations: E0107, E0403, E0412. | ||
For more information about an error, try `rustc --explain E0107`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't object to this code here, but I did wonder: does this pattern (of iterating over the substs looking for evidence of a type error recovery) occur elsewhere? Does it deserve its own helper routine on
substs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not expect this pattern to be common in the codebase.