Rollup of 6 pull requests #86626

JohnTitor · 2021-06-25T14:40:17Z

Successful merges:

Add go_to_first query param to jump to first result #85876 (Add go_to_first query param to jump to first result)
Change how edition based future compatibility warnings are handled #86330 (Change how edition based future compatibility warnings are handled)
Rustdoc: Do not list impl when trait has doc(hidden) #86513 (Rustdoc: Do not list impl when trait has doc(hidden))
Use #[non_exhaustive] where appropriate #86592 (Use #[non_exhaustive] where appropriate)
chore(rustdoc): remove unused members of RenderType #86608 (chore(rustdoc): remove unused members of RenderType)
Update compiler-builtins #86624 (Update compiler-builtins)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Due to the std/alloc split, it is not possible to make `alloc::collections::TryReserveError::AllocError` non-exhaustive without having an unstable, doc-hidden method to construct (which negates the benefits from `#[non_exhaustive]`.

Commit e629381 removes the only place these members variables are actually read.

…search result

Add `go_to_first` query param to jump to first result Fixes rust-lang#84214 Note that while the issue initially wanted to navigate to an entry on exact match, the discussion settled on using a query parameter (`&go_to_first=true`) instead, regardless of exact or partial match. Demonstration is attached https://user-images.githubusercontent.com/4934853/120258768-7ff28980-c247-11eb-8c8f-1a2ceb242788.mp4

…tsakis Change how edition based future compatibility warnings are handled This fixes rust-lang#85894 by updating how future compatibility lints work. This makes it more apparent that future compatibility warnings can happen for several different reasons. For now `FutureCompatibilityReasons` are limited to three reasons, but we can easily add more. This also updates the generated warning for FCW's that signal code that will error in a future edition. This makes the diagnostics between FCWs at edition boundaries more distinct from those not happening at an edition boundary. r? `@m-ou-se`

…=danielhenrymantilla Rustdoc: Do not list impl when trait has doc(hidden) Fixes rust-lang#86448.

Use `#[non_exhaustive]` where appropriate Due to the std/alloc split, it is not possible to make `alloc::collections::TryReserveError::AllocError` non-exhaustive without having an unstable, doc-hidden method to construct (which negates the benefits from `#[non_exhaustive]`). `@rustbot` label +C-cleanup +T-libs +S-waiting-on-review

…, r=jyn514 chore(rustdoc): remove unused members of RenderType PR rust-lang#86561 removes the only place the `generics` member is read. This PR does even more cleanup.

…r=Amanieu Update compiler-builtins r? `@Amanieu`

JohnTitor · 2021-06-25T14:40:32Z

@bors r+ rollup=never p=6

bors · 2021-06-25T14:40:33Z

📌 Commit fac113a has been approved by JohnTitor

bors · 2021-06-25T15:01:13Z

⌛ Testing commit fac113a with merge 87f62f38dade77b900d64245653730959e891c03...

rust-log-analyzer · 2021-06-25T15:12:47Z

The job x86_64-gnu-llvm-10 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

doc tests for: /checkout/src/doc/rustdoc/src/unstable-features.md
doc tests for: /checkout/src/doc/rustdoc/src/website-features.md


command did not execute successfully: "/checkout/obj/build/bootstrap/debug/rustdoc" "-Wrustdoc::invalid_codeblock_attributes" "-Dwarnings" "-Znormalize-docs" "-Z" "unstable-options" "--test" "/checkout/src/doc/rustdoc/src/website-features.md" "--test-args" ""

stdout ----

running 2 tests
running 2 tests
test /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 12) ... FAILED
test /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 17) ... FAILED
failures:


---- /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 12) stdout ----
error: expected expression, found `}`
 --> /checkout/src/doc/rustdoc/src/website-features.md:14:1
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() {
  |                                                                                                                - while parsing this struct
3 | https://doc.rust-lang.org/stable/std/?search=%s
4 | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() }


error: struct literal body without path
 --> /checkout/src/doc/rustdoc/src/website-features.md:12:112
  |
2 |   fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() {
  |  ________________________________________________________________________________________________________________^
3 | | https://doc.rust-lang.org/stable/std/?search=%s
4 | | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() }
  |
  |
help: you might have forgotten to add the struct literal inside the block
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() { SomeStruct {
3 | https://doc.rust-lang.org/stable/std/?search=%s
4 | } } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() }

error: aborting due to 2 previous errors

Couldn't compile the test.
Couldn't compile the test.
---- /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 17) stdout ----
error: expected expression, found `}`
 --> /checkout/src/doc/rustdoc/src/website-features.md:19:1
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() {
  |                                                                                                                - while parsing this struct
3 | https://doc.rust-lang.org/stable/std/?search=%s&go_to_first=true
4 | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() }


error: struct literal body without path
 --> /checkout/src/doc/rustdoc/src/website-features.md:17:112
  |
2 |   fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() {
  |  ________________________________________________________________________________________________________________^
3 | | https://doc.rust-lang.org/stable/std/?search=%s&go_to_first=true
4 | | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() }
  |
  |
help: you might have forgotten to add the struct literal inside the block
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() { SomeStruct {
3 | https://doc.rust-lang.org/stable/std/?search=%s&go_to_first=true
4 | } } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() }

error: aborting due to 2 previous errors

Couldn't compile the test.
Couldn't compile the test.

failures:
    /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 12)
    /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 17)
test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s


stderr ----

rust-log-analyzer · 2021-06-25T15:34:43Z

The job x86_64-gnu-llvm-10 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


doc tests for: /checkout/src/doc/rustdoc/src/website-features.md

running 2 tests
test /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 12) ... FAILED
test /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 17) ... FAILED
failures:


---- /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 12) stdout ----
error: expected expression, found `}`
 --> /checkout/src/doc/rustdoc/src/website-features.md:14:1
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() {
  |                                                                                                                - while parsing this struct
3 | https://doc.rust-lang.org/stable/std/?search=%s
4 | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() }


error: struct literal body without path
 --> /checkout/src/doc/rustdoc/src/website-features.md:12:112
  |
2 |   fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() {
  |  ________________________________________________________________________________________________________________^
3 | | https://doc.rust-lang.org/stable/std/?search=%s
4 | | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() }
  |
  |
help: you might have forgotten to add the struct literal inside the block
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() { SomeStruct {
3 | https://doc.rust-lang.org/stable/std/?search=%s
4 | } } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_12_0() }

error: aborting due to 2 previous errors

Couldn't compile the test.
Couldn't compile the test.
---- /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 17) stdout ----
error: expected expression, found `}`
 --> /checkout/src/doc/rustdoc/src/website-features.md:19:1
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() {
  |                                                                                                                - while parsing this struct
3 | https://doc.rust-lang.org/stable/std/?search=%s&go_to_first=true
4 | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() }


error: struct literal body without path
 --> /checkout/src/doc/rustdoc/src/website-features.md:17:112
  |
2 |   fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() {
  |  ________________________________________________________________________________________________________________^
3 | | https://doc.rust-lang.org/stable/std/?search=%s&go_to_first=true
4 | | } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() }
  |
  |
help: you might have forgotten to add the struct literal inside the block
  |
2 | fn main() { #[allow(non_snake_case)] fn _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() { SomeStruct {
3 | https://doc.rust-lang.org/stable/std/?search=%s&go_to_first=true
4 | } } _doctest_main__checkout_src_doc_rustdoc_src_website_features_md_17_0() }

error: aborting due to 2 previous errors

Couldn't compile the test.
Couldn't compile the test.

failures:
    /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 12)
    /checkout/src/doc/rustdoc/src/website-features.md - Website_features::Custom_search_engines (line 17)
test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s




command did not execute successfully: "/checkout/obj/build/bootstrap/debug/rustdoc" "-Wrustdoc::invalid_codeblock_attributes" "-Dwarnings" "-Znormalize-docs" "-Z" "unstable-options" "--test" "/checkout/src/doc/rustdoc/src/website-features.md" "--test-args" ""


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:30:34

bors · 2021-06-25T15:35:42Z

💔 Test failed - checks-actions

jeanlucthumm · 2021-06-25T15:56:22Z

Looks like the tests are interpreting my URL code snippet in the rustdoc book as rust code and trying to run it. I bet there's a way to make it ignore the code block, I'll do some digging.

fee1-dead and others added 20 commits June 22, 2021 04:15

Do not list impl when trait has doc(hidden)

bd7caf4

Account for more cases

0aaefff

Use #[non_exhaustive] where appropriate

3f14f4b

Due to the std/alloc split, it is not possible to make `alloc::collections::TryReserveError::AllocError` non-exhaustive without having an unstable, doc-hidden method to construct (which negates the benefits from `#[non_exhaustive]`.

chore(rustdoc): remove unused members of RenderType

14ca894

Commit e629381 removes the only place these members variables are actually read.

Add go_to_first boolean query param to immeidately jump to the first …

e2635ee

…search result

Add Website features page to rustdoc book

867a360

Renamed test and added test for same crate

9a63434

Change how edition based future compatibility warnings are handled

23176f6

Address PR feedback

7b3940f

Add back missing doc

5ef071e

Fix new lints

15eae85

Fix new broken tests

ef08c6b

Fix clippy test

51f223e

Update compiler-builtins

98ae57d

Rollup merge of rust-lang#86513 - fee1-dead:cross-crate-doc-hidden, r…

8875e72

…=danielhenrymantilla Rustdoc: Do not list impl when trait has doc(hidden) Fixes rust-lang#86448.

Rollup merge of rust-lang#86608 - notriddle:notriddle/cleanup-rustdoc…

14a3809

…, r=jyn514 chore(rustdoc): remove unused members of RenderType PR rust-lang#86561 removes the only place the `generics` member is read. This PR does even more cleanup.

Rollup merge of rust-lang#86624 - jethrogb:update-compiler_builtins, …

fac113a

…r=Amanieu Update compiler-builtins r? `@Amanieu`

rustbot added the rollup A PR which is a rollup label Jun 25, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 25, 2021

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 25, 2021

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2021

JohnTitor mentioned this pull request Jun 25, 2021

Add go_to_first query param to jump to first result #85876

Merged

JohnTitor closed this Jun 25, 2021

JohnTitor deleted the rollup-8jcidld branch June 25, 2021 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #86626

Rollup of 6 pull requests #86626

JohnTitor commented Jun 25, 2021

JohnTitor commented Jun 25, 2021

bors commented Jun 25, 2021

bors commented Jun 25, 2021

rust-log-analyzer commented Jun 25, 2021

rust-log-analyzer commented Jun 25, 2021

bors commented Jun 25, 2021

jeanlucthumm commented Jun 25, 2021

Rollup of 6 pull requests #86626

Rollup of 6 pull requests #86626

Conversation

JohnTitor commented Jun 25, 2021

JohnTitor commented Jun 25, 2021

bors commented Jun 25, 2021

bors commented Jun 25, 2021

rust-log-analyzer commented Jun 25, 2021

rust-log-analyzer commented Jun 25, 2021

bors commented Jun 25, 2021

jeanlucthumm commented Jun 25, 2021