Use https for sourceforge during CI #86583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #86573) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I followed the new upstream of expat to github in the second commit. If you prefer to stay on sourceforge I could remove the second commit. However, I think we should follow the project and maybe have another mechanism to track upstream changes. Cheers, |
|
Thanks! @bors r+ |
|
📌 Commit bcb7b39 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jun 24, 2021
…henkov Use HTTPS links where possible While looking at rust-lang#86583, I wondered how many other (insecure) HTTP links were in `rustc`. This changes most other `http` links to `https`. While most of the links are in comments or documentation, there are a few other HTTP links that are used by CI that are changed to HTTPS. Notes: - I didn't change any to or in licences - Some links don't support HTTPS :( - Some `http` links were dead, in those cases I upgraded them to their new places (all of which used HTTPS)
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jun 24, 2021
Use https for sourceforge during CI I saw that we use http during CI opening up the CI process to on the wire tampering. based on rust-lang#86573 r? `@pietroalbini`
|
⌛ Testing commit bcb7b39 with merge dabe8a175bdb0ae08817a377807785d70d1169ff... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
src/ci/docker/host-x86_64/dist-riscv64-linux/riscv64-unknown-linux-gnu.config
Outdated
Show resolved
Hide resolved
|
@bors r+ rollup=iffy |
|
📌 Commit 10b83cd has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 26, 2021
…nkov Use HTTPS links where possible While looking at rust-lang#86583, I wondered how many other (insecure) HTTP links were in `rustc`. This changes most other `http` links to `https`. While most of the links are in comments or documentation, there are a few other HTTP links that are used by CI that are changed to HTTPS. Notes: - I didn't change any to or in licences - Some links don't support HTTPS :( - Some `http` links were dead, in those cases I upgraded them to their new places (all of which used HTTPS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that we use http during CI opening up the CI process to on the wire tampering.
based on #86573
r? @pietroalbini