Remove Ipv4Addr::is_ietf_protocol_assignment
#86439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-io
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
CDirkx
force-pushed
the
ip-protocol-assignment
branch
from
850648c
to
a26237e
Compare
CDirkx
commented
Jun 19, 2021
Comment on lines
-452
to
+446
| check!("192.0.0.0", ietf_protocol_assignment); | ||
| check!("192.0.0.255", ietf_protocol_assignment); | ||
| check!("192.0.0.100", ietf_protocol_assignment); | ||
| check!("192.0.0.0"); | ||
| check!("192.0.0.255"); | ||
| check!("192.0.0.100"); |
There was a problem hiding this comment.
At first I had removed these lines entirely, but I decided to keep them as a check that these addresses are not global; is_global should not return true for these addresses.
This comment has been minimized.
This comment has been minimized.
rustbot
added
T-libs-api
JohnCSimon
added
S-waiting-on-review
camelid
added
S-waiting-on-review
|
Thanks. If anyone ever does find a use for this function, we can always add it back again. @bors r+ |
|
📌 Commit a26237e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2021
Rollup of 13 pull requests Successful merges: - rust-lang#86183 (Change environment variable getters to error recoverably) - rust-lang#86439 (Remove `Ipv4Addr::is_ietf_protocol_assignment`) - rust-lang#86509 (Move `os_str_bytes` to `sys::unix`) - rust-lang#86593 (Partially stabilize `const_slice_first_last`) - rust-lang#86936 (Add documentation for `Ipv6MulticastScope`) - rust-lang#87282 (Ensure `./x.py dist` adheres to `build.tools`) - rust-lang#87468 (Update rustfmt) - rust-lang#87504 (Update mdbook.) - rust-lang#87608 (Remove unused field `Session.system_library_path`) - rust-lang#87629 (Consistent spelling of "adapter" in the standard library) - rust-lang#87633 (Update compiler_builtins to fix i128 shift/mul on thumbv6m) - rust-lang#87644 (Recommend `swap_remove` in `Vec::remove` docs) - rust-lang#87653 (mark a UB doctest as no_run) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
28 tasks
jstasiak
added a commit
to jstasiak/rust-libs-team
that referenced
this pull request
Dec 7, 2023
The is_unicast_site_local() method has been gone since Rust 1.55[1] and is_ietf_protocol_assignment() since 1.56[2]. I had to run this tool to test something, saw it wouldn't build with modern Rust. [1] rust-lang/rust#85820 [2] rust-lang/rust#86439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unstable method
Ipv4Addr::is_ietf_protocol_assignment, as I suggested in #85612 (comment). The method was added in #60145, as far as I can tell primarily for the implementation ofIpv4Addr::is_global(addresses reserved for IETF protocol assignment are not globally reachable unless otherwise specified).The method was added in 2019, but I haven't been able to find any open-source code using this method so far. I'm also having a hard time coming up with a usecase for specifically this method; knowing that an address is reserved for future protocols doesn't allow you to do much with it, especially since now some of those addresses are indeed assigned to a protocol and have their own behaviour (and might even be defined to be globally reachable, so if that is what you care about it is always more accurate to call
!is_global(), instead ofis_ietf_protocol_assignment()).Because of these reasons, I propose removing the method (or alternatively make it a private helper for
is_global) and also not introduceIpv6Addr::is_ietf_protocol_assignmentandIpAddr::is_ietf_protocol_assignmentin the future.