Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrowck: don't calculate unused info when reporting move errors #81129

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Borrowck: don't calculate unused info when reporting move errors #81129

merged 1 commit into from
Feb 11, 2021

Conversation

bugadani
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2021
@petrochenkov
Copy link
Contributor

Not familiar with the code, but this looks reasonable assuming the comments are correct.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2021
@bors

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 10, 2021

📌 Commit 3c1d792 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 11, 2021
@JohnTitor
Rollup merge of rust-lang#81129 - bugadani:lighter-move-errors, r=pet…
c202114 
…rochenkov

Borrowck: don't calculate unused info when reporting move errors
@JohnTitor JohnTitor mentioned this pull request Feb 11, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 11, 2021
@JohnTitor
Rollup merge of rust-lang#81129 - bugadani:lighter-move-errors, r=pet…
b16c54c 
…rochenkov

Borrowck: don't calculate unused info when reporting move errors
@JohnTitor JohnTitor mentioned this pull request Feb 11, 2021
Closed
@bors
Copy link
Contributor

bors commented Feb 11, 2021

⌛ Testing commit 3c1d792 with merge 2918062...

@bors
Copy link
Contributor

bors commented Feb 11, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 2918062 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2021
@bors bors merged commit 2918062 into rust-lang:master Feb 11, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 11, 2021
@bugadani bugadani deleted the lighter-move-errors branch February 11, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bugadani @rust-highfive @petrochenkov @bors @rustbot