-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #77038
Rollup of 13 pull requests #77038
Commits on Sep 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 28db521 - Browse repository at this point
Copy the full SHA 28db521View commit details
Commits on Sep 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ec7f9b9 - Browse repository at this point
Copy the full SHA ec7f9b9View commit details
Commits on Sep 12, 2020
-
Make some methods of
Pin
unstable constMake the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654
Configuration menu - View commit details
-
Copy full SHA for 8f27e3c - Browse repository at this point
Copy the full SHA 8f27e3cView commit details
Commits on Sep 13, 2020
-
Only insert StorageDeads if we actually removed one. Fixes an issue where we added StorageDead to a place with no StorageLive
Configuration menu - View commit details
-
Copy full SHA for e5447a2 - Browse repository at this point
Copy the full SHA e5447a2View commit details
Commits on Sep 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for eede953 - Browse repository at this point
Copy the full SHA eede953View commit details -
Otherwise, we may not have a standard library built for the native "host" target of the rustc being run.
Configuration menu - View commit details
-
Copy full SHA for 7e24136 - Browse repository at this point
Copy the full SHA 7e24136View commit details -
Build rustdoc for cross-compiled targets
This isn't an issue for most folks who use x.py dist, which will directly depend on this. But for x.py build, if we don't properly set target here rustdoc will not be built. Currently, there is not a default-on step for generating a rustc for a given target either, so we will fail to build a rustc as well.
Configuration menu - View commit details
-
Copy full SHA for bd4e0af - Browse repository at this point
Copy the full SHA bd4e0afView commit details
Commits on Sep 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 363aff0 - Browse repository at this point
Copy the full SHA 363aff0View commit details
Commits on Sep 18, 2020
-
Make some methods of
Pin<&mut T>
unstable constMake the following methods unstable const under the `const_pin` feature: - `into_ref` - `get_mut` - `get_unchecked_mut`
Configuration menu - View commit details
-
Copy full SHA for e3c6e46 - Browse repository at this point
Copy the full SHA e3c6e46View commit details
Commits on Sep 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2a00dda - Browse repository at this point
Copy the full SHA 2a00ddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6734230 - Browse repository at this point
Copy the full SHA 6734230View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b3419 - Browse repository at this point
Copy the full SHA 65b3419View commit details -
use if let instead of single match arm expressions to compact code an…
…d reduce nesting (clippy::single_match)
Configuration menu - View commit details
-
Copy full SHA for c690c82 - Browse repository at this point
Copy the full SHA c690c82View commit details
Commits on Sep 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 88a29e6 - Browse repository at this point
Copy the full SHA 88a29e6View commit details -
Update library/std/src/process.rs
Co-authored-by: David Tolnay <dtolnay@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0acb0ed - Browse repository at this point
Copy the full SHA 0acb0edView commit details -
Don't recommend ManuallyDrop to customize drop order
See https://internals.rust-lang.org/t/need-for-controlling-drop-order-of-fields/12914/21 for the discussion. TL;DR: ManuallyDrop is unsafe and footguny, but you can just ask the compiler to do all the work for you by re-ordering declarations.
Configuration menu - View commit details
-
Copy full SHA for 60b102d - Browse repository at this point
Copy the full SHA 60b102dView commit details -
- Add a changelog and instructions for updating it - Use `changelog-seen` in `config.toml` and `VERSION` in bootstrap to determine whether the changelog has been read - Nag people if they haven't read the x.py changelog + Print message twice to make sure it's seen - Give different error messages depending on whether the version needs to be updated or added
2Configuration menu - View commit details
-
Copy full SHA for fe6fc55 - Browse repository at this point
Copy the full SHA fe6fc55View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4b4a2f - Browse repository at this point
Copy the full SHA b4b4a2fView commit details -
Remove cast to usize for BytePos and CharPos
The case shouldn't be necessary and implicitly truncating BytePos is not desirable.
Configuration menu - View commit details
-
Copy full SHA for 9a1f177 - Browse repository at this point
Copy the full SHA 9a1f177View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63195ec - Browse repository at this point
Copy the full SHA 63195ecView commit details -
Don't use
zip
to compare iterators during pretty-print hackIf the right-hand iterator has exactly one more element than the left-hand iterator, then both iterators will be fully consumed, but the extra element will never be compared.
Configuration menu - View commit details
-
Copy full SHA for f5d71a9 - Browse repository at this point
Copy the full SHA f5d71a9View commit details -
MIR pass to remove unneeded drops on types not needing drop
This is heavily dependent on MIR inlining running to actually see the drop statement
Configuration menu - View commit details
-
Copy full SHA for 40a5dc8 - Browse repository at this point
Copy the full SHA 40a5dc8View commit details -
Co-authored-by: Andreas Jonson <andjo403@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e6942ae - Browse repository at this point
Copy the full SHA e6942aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b61fbc - Browse repository at this point
Copy the full SHA 9b61fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d372455 - Browse repository at this point
Copy the full SHA d372455View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2da2e - Browse repository at this point
Copy the full SHA 1b2da2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb9f3a - Browse repository at this point
Copy the full SHA dfb9f3aView commit details
Commits on Sep 22, 2020
-
Rollup merge of rust-lang#76131 - Aaron1011:fix/pretty-print-zip, r=lcnr
Don't use `zip` to compare iterators during pretty-print hack If the right-hand iterator has exactly one more element than the left-hand iterator, then both iterators will be fully consumed, but the extra element will never be compared. Split out from rust-lang#76130
Configuration menu - View commit details
-
Copy full SHA for 6be8212 - Browse repository at this point
Copy the full SHA 6be8212View commit details -
Rollup merge of rust-lang#76150 - matklad:droporder, r=withoutboats
Don't recommend ManuallyDrop to customize drop order See https://internals.rust-lang.org/t/need-for-controlling-drop-order-of-fields/12914/21 for the discussion. TL;DR: ManuallyDrop is unsafe and footguny, but you can just ask the compiler to do all the work for you by re-ordering declarations. Specifically, the original example from the docs is much better written as ```rust struct Peach; struct Banana; struct Melon; struct FruitBox { melon: Melon, // XXX: mind the relative drop order of the fields below peach: Peach, banana: Banana, } ```
Configuration menu - View commit details
-
Copy full SHA for e9aaa3b - Browse repository at this point
Copy the full SHA e9aaa3bView commit details -
Rollup merge of rust-lang#76275 - FedericoPonzi:immutable-write-impl-…
…73836, r=dtolnay Implementation of Write for some immutable ref structs Fixes rust-lang#73836
Configuration menu - View commit details
-
Copy full SHA for b062780 - Browse repository at this point
Copy the full SHA b062780View commit details -
Rollup merge of rust-lang#76489 - GuillaumeGomez:add-explanation-e075…
…6, r=jyn514 Add explanation for E0756 r? @pickfire
Configuration menu - View commit details
-
Copy full SHA for b7a6aae - Browse repository at this point
Copy the full SHA b7a6aaeView commit details -
Rollup merge of rust-lang#76581 - lcnr:bound-too-generic, r=eddyb
do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 7a91e17 - Browse repository at this point
Copy the full SHA 7a91e17View commit details -
Rollup merge of rust-lang#76626 - jyn514:x.py-changelog, r=Mark-Simul…
…acrum Add a changelog for x.py and nag contributors until they read it Add a changelog for x.py - Add a changelog and instructions for updating it - Use `changelog-seen` in `config.toml` and `VERSION` in bootstrap to determine whether the changelog has been read. There's no way to tie reading the changelog to updating the version, so unfortunately they still have to update `config.toml` manually. Actually reading the changelog is optional, anyone can set `changelog-seen = N` without reading (although it's not recommended). - Nag people if they haven't read the x.py changelog + Print message twice to make sure it's seen - Give different error messages depending on whether the version needs to be updated or added Closes rust-lang#76617 r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for a65a244 - Browse repository at this point
Copy the full SHA a65a244View commit details -
Rollup merge of rust-lang#76655 - CDirkx:const-pin, r=ecstatic-morse
Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse
Configuration menu - View commit details
-
Copy full SHA for 4b4cfdd - Browse repository at this point
Copy the full SHA 4b4cfddView commit details -
Rollup merge of rust-lang#76659 - simonvandel:76432, r=oli-obk
SimplifyComparisonIntegral: fix miscompilation Fixes rust-lang#76432 Only insert StorageDeads if we actually removed one. Fixes an issue where we added StorageDead to a place with no StorageLive r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 8d641ce - Browse repository at this point
Copy the full SHA 8d641ceView commit details -
Rollup merge of rust-lang#76673 - simonvandel:remove-unneeded-drops, …
…r=oli-obk MIR pass to remove unneeded drops on types not needing drop This is heavily dependent on MIR inlining running to actually see the drop statement. Do we want to special case replacing a call to std::mem::drop with a goto aswell?
Configuration menu - View commit details
-
Copy full SHA for 0e5bcba - Browse repository at this point
Copy the full SHA 0e5bcbaView commit details -
Rollup merge of rust-lang#76783 - lzutao:rd_impl_kind, r=GuillaumeGomez
Only get ImplKind::Impl once With this, the code panics in one place instead of two.
Configuration menu - View commit details
-
Copy full SHA for 5e46051 - Browse repository at this point
Copy the full SHA 5e46051View commit details -
Rollup merge of rust-lang#76799 - Mark-Simulacrum:fix-cross-compile-d…
…ist, r=alexcrichton Fix cross compiling dist/build invocations I am uncertain why the first commit is not affecting CI. I suspect it's because we pass --disable-docs on most of our cross-compilation builders. The second commit doesn't affect CI because CI runs x.py dist, not x.py build. Both commits are standalone; together they should resolve rust-lang#76733. The first commit doesn't really fix that issue but rather just fixes cross-compiled x.py dist, resolving a bug introduced in rust-lang#76549.
Configuration menu - View commit details
-
Copy full SHA for a282d1e - Browse repository at this point
Copy the full SHA a282d1eView commit details -
Rollup merge of rust-lang#76888 - matthiaskrgr:clippy_single_match_2,…
… r=Dylan-DPC use if let instead of single match arm expressions use if let instead of single match arm expressions to compact code and reduce nesting (clippy::single_match)
Configuration menu - View commit details
-
Copy full SHA for 42b3303 - Browse repository at this point
Copy the full SHA 42b3303View commit details -
Rollup merge of rust-lang#77022 - Juici:master, r=lcnr
Reduce boilerplate for BytePos and CharPos Reduces boilerplate code for BytePos and CharPos by using a macro to implement shared traits.
Configuration menu - View commit details
-
Copy full SHA for b441d26 - Browse repository at this point
Copy the full SHA b441d26View commit details