Clean up diagnostics for arithmetic operation errors

[varkor]

Plus a small tweak to a range pattern error message.

[rust-highfive]

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

[ecstatic-morse]

@bors r+

[bors]

📌 Commit 220cb278997079087ed3b3ed6e73d60d80d770d7 has been approved by ecstatic-morse

[bors]

☔ The latest upstream changes (presumably #76854) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[varkor]

@bors r=ecstatic-morse

[bors]

📌 Commit e2e000a has been approved by ecstatic-morse

[jyn514]

Failed in rollup (#76951):

 ---- [ui] ui/lint/lint-exceeding-bitshifts.rs#opt stdout ----
diff of stderr:

140	  --> $DIR/lint-exceeding-bitshifts.rs:77:15
141	   |
142	LL |       let n = 1_isize << BITS;
-	   |               ^^^^^^^^^^^^^^^ attempt to shift left by `64_usize`, which would overflow
+	   |               ^^^^^^^^^^^^^^^ attempt to shift left by `32_usize`, which would overflow
144	
145	warning: this arithmetic operation will overflow
146	  --> $DIR/lint-exceeding-bitshifts.rs:78:15

147	   |
148	LL |       let n = 1_usize << BITS;
-	   |               ^^^^^^^^^^^^^^^ attempt to shift left by `64_usize`, which would overflow
+	   |               ^^^^^^^^^^^^^^^ attempt to shift left by `32_usize`, which would overflow
150	
151	warning: 24 warnings emitted

Looks like you might need to normalize the size of BITS in the diagnostic?

[jyn514]

@bors r-

[jyn514]

Looks spurious:

Run src/ci/scripts/install-clang.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0  424M    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  1  424M    1 6779k    0     0  4627k      0  0:01:33  0:00:01  0:01:32 4624k
  3  424M    3 12.8M    0     0  6190k      0  0:01:10  0:00:02  0:01:08 6190k
curl: (56) SSLRead() return error -9806
clang+llvm-10.0.0-x86_64-apple-darwin/lib/libLLVMCore.a: Lzma library error:  No progress is possible

@bors retry

[bors]

⌛ Testing commit 5851d62 with merge 9e0179acfb7ebbc6a8d2d2b41ec3423bb266fa7b...

[bors]

💔 Test failed - checks-actions

[jyn514]

You need to bless the fulldeps tests:

failures:
    [run-make] run-make-fulldeps/instrument-coverage-mir-cov-html-base
    [run-make] run-make-fulldeps/instrument-coverage-mir-cov-html-link-dead-code

[varkor]

I addressed the fulldeps, but unfortunately I couldn't run the entire test suite on my computer (it's been acting up lately), so I'm not certain there isn't another issue. Hopefully that's the last of them.

@bors r=ecstatic-morse

[bors]

📌 Commit c0b1057 has been approved by ecstatic-morse

[bors]

⌛ Testing commit c0b1057 with merge 1ddb2bfd14764732f023ef2edbc94525e91402a1...

[bors]

💥 Test timed out

[jyn514]

@bors retry

[bors]

⌛ Testing commit c0b1057 with merge 4d52dc4...

[bors]

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 4d52dc4 to master...