Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Vec UI tests to unit tests when possible #76718

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Move Vec UI tests to unit tests when possible #76718

merged 5 commits into from
Nov 5, 2020

Conversation

poliorcetics
Copy link
Contributor

Helps with #76268.

I'm moving the tests using Vec or VecDeque.

@rustbot modify labels: A-testsuite C-cleanup T-libs

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 14, 2020
@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 15, 2020

📌 Commit 44b7cc4212d5527fe936074d4d8f08d7cb5907ac has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
@poliorcetics
Copy link
Contributor Author

I'm sorry, I forgot to add WIP to the title, I'm not done at all with this PR

@poliorcetics
Copy link
Contributor Author

It can be merged and I can open another but that would separate related work across two PRs

@poliorcetics poliorcetics changed the title Move Vec UI tests to unit tests when possible WIP: Move Vec UI tests to unit tests when possible Sep 15, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2020
@bors

This comment has been minimized.

Sign in to view
@poliorcetics
Copy link
Contributor Author

I will look into before the end of the week, I'm currently busy with the survey's translation.

@poliorcetics

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2020
@bors

This comment has been minimized.

Sign in to view
@poliorcetics
Copy link
Contributor Author

I think this can be merged as is, more work can be done in another PR without problems and hitting more merge conflicts sounds painful.

@jyn514
Copy link
Member

jyn514 commented Nov 4, 2020

@bors r+ rollup

For posterity, git show -w --reverse --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change dda2b5e3e260c14b868c494008af1c8981eaa5a8.. made this so much easier to review.

@bors
Copy link
Contributor

bors commented Nov 4, 2020

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove WIP from this PR's title when it is ready for review.

@jyn514 jyn514 changed the title WIP: Move Vec UI tests to unit tests when possible Move Vec UI tests to unit tests when possible Nov 4, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 4, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2020

📌 Commit 1bdee96 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 5, 2020
@JohnTitor
Rollup merge of rust-lang#76718 - poliorcetics:vec-ui-to-unit-test, r…
30bb1f9 
…=jyn514

Move Vec UI tests to unit tests when possible

Helps with rust-lang#76268.

I'm moving the tests using `Vec` or `VecDeque`.

`@rustbot` modify labels: A-testsuite C-cleanup T-libs
@JohnTitor JohnTitor mentioned this pull request Nov 5, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 5, 2020
@JohnTitor
Rollup merge of rust-lang#76718 - poliorcetics:vec-ui-to-unit-test, r…
c63364b 
…=jyn514

Move Vec UI tests to unit tests when possible

Helps with rust-lang#76268.

I'm moving the tests using `Vec` or `VecDeque`.

``@rustbot`` modify labels: A-testsuite C-cleanup T-libs
@JohnTitor JohnTitor mentioned this pull request Nov 5, 2020
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 5, 2020
@m-ou-se
Rollup merge of rust-lang#76718 - poliorcetics:vec-ui-to-unit-test, r…
7a14022 
…=jyn514

Move Vec UI tests to unit tests when possible

Helps with rust-lang#76268.

I'm moving the tests using `Vec` or `VecDeque`.

```@rustbot``` modify labels: A-testsuite C-cleanup T-libs
This was referenced Nov 5, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2020
@bors
Auto merge of rust-lang#78767 - m-ou-se:rollup-eu5wgxl, r=m-ou-se
f7801d6 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#76718 (Move Vec UI tests to unit tests when possible)
 - rust-lang#78093 (Clean up docs for 'as' keyword)
 - rust-lang#78425 (Move f64::NAN ui tests into `library`)
 - rust-lang#78465 (Change as_str → to_string in proc_macro::Ident::span() docs)
 - rust-lang#78584 (Add keyboard handling to the theme picker menu)
 - rust-lang#78716 (Array trait impl comment/doc fixes)
 - rust-lang#78727 ((rustdoc) fix test for trait impl display)
 - rust-lang#78733 (fix a couple of clippy warnings:)
 - rust-lang#78735 (Simplify the implementation of `get_mut` (no unsafe))
 - rust-lang#78738 (Move range in ui test to ops test in library/core)
 - rust-lang#78739 (Fix ICE on type error in async function)
 - rust-lang#78742 (make intern_const_alloc_recursive return error)
 - rust-lang#78756 (Update cargo)
 - rust-lang#78757 (Improve and clean up some intra-doc links)
 - rust-lang#78758 (Fixed typo in comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 55f4b80 into rust-lang:master Nov 5, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@withoutboats withoutboats

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@poliorcetics @rust-highfive @jyn514 @bors @withoutboats @rustbot