Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for async functions when suggesting new named lifetime #75867

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Account for async functions when suggesting new named lifetime #75867

merged 1 commit into from
Aug 30, 2020

Conversation

estebank
Copy link
Contributor

Fix #75850.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2020
@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2020
@estebank
Copy link
Contributor Author

Nominating for beta backport simply because it is already in stable, but there's no harm on letting this ride the train.

pickfire
pickfire approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 27, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2020

📌 Commit 35e166e has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2020
@bors
Copy link
Contributor

bors commented Aug 30, 2020

⌛ Testing commit 35e166e with merge b1d092c...

@bors
Copy link
Contributor

bors commented Aug 30, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing b1d092c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 30, 2020
@bors bors merged commit b1d092c into rust-lang:master Aug 30, 2020
@bors bors mentioned this pull request Aug 30, 2020
Merged
@Mark-Simulacrum Mark-Simulacrum added this to the 1.47.0 milestone Sep 17, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 17, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2020
@bors
Auto merge of rust-lang#76852 - Mark-Simulacrum:beta-next, r=Mark-Sim…
755064b 
…ulacrum

[beta] backports

* Ignore rustc_private items from std docs rust-lang#76571
* Fix HashMap visualizers in Visual Studio (Code) rust-lang#76389
* Account for version number in NtIdent hack rust-lang#76331
* Account for async functions when suggesting new named lifetime rust-lang#75867
* Fix loading pretty-printers in rust-lldb script rust-lang#76015

This also bumps to the released stable compiler.
@apiraino apiraino removed the P-low Low priority label Feb 8, 2022
@estebank estebank deleted the async-lt-sugg-fix branch November 9, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@matthewjasper matthewjasper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

"use of undeclared lifetime" error on async method has invalid suggestion (lifetime in parameter position)
9 participants
@estebank @rust-highfive @spastorino @matthewjasper @bors @pickfire @Mark-Simulacrum @apiraino @rustbot