Move to doc links inside std/time.rs #75371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-intra-doc-links
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
pickfire
reviewed
Aug 11, 2020
|
❤️ these sorts of PRs make me think all the time I put in was worth it :) @bors r+ rollup |
|
📌 Commit bd01bf9 has been approved by |
bors
added
S-waiting-on-bors
pickfire
reviewed
Aug 12, 2020
| @@ -368,7 +361,7 @@ impl Add<Duration> for Instant { | |||
| /// This function may panic if the resulting point in time cannot be represented by the | |||
| /// underlying data structure. See [`checked_add`] for a version without panic. | |||
| /// | |||
| /// [`checked_add`]: ../../std/time/struct.Instant.html#method.checked_add | |||
| /// [`checked_add`]: Instant::checked_add | |||
There was a problem hiding this comment.
We could also do the same trick here.
There was a problem hiding this comment.
This is already being merged so I won't modify further but a follow up PR would probably be accepted without any problem. 😃
pickfire
reviewed
Aug 12, 2020
| @@ -544,7 +527,7 @@ impl Add<Duration> for SystemTime { | |||
| /// This function may panic if the resulting point in time cannot be represented by the | |||
| /// underlying data structure. See [`checked_add`] for a version without panic. | |||
| /// | |||
| /// [`checked_add`]: ../../std/time/struct.SystemTime.html#method.checked_add | |||
| /// [`checked_add`]: SystemTime::checked_add | |||
There was a problem hiding this comment.
And here, it would be clearer. Reading the code directly is way better now, also the docs will be more explicit.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#74521 (older toolchains not valid anymore) - rust-lang#74960 (Fix regionck failure when converting Index to IndexMut) - rust-lang#75234 (Update asm! documentation in unstable book) - rust-lang#75368 (Move to doc links inside the prelude) - rust-lang#75371 (Move to doc links inside std/time.rs) - rust-lang#75394 (Add a function to `TyCtxt` for computing an `Allocation` for a `static` item's initializer) - rust-lang#75395 (Switch to intra-doc links in library/std/src/os/*/fs.rs) - rust-lang#75422 (Accept more safety comments) - rust-lang#75424 (fix wrong word in documentation) Failed merges: r? @ghost
jyn514
removed
the
T-rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #75080.
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc