Clean up E0741 error explanation #74977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
pickfire
reviewed
Aug 1, 2020
| @@ -9,12 +10,15 @@ struct A; | |||
| struct B<const X: A>; // error! | |||
| ``` | |||
|
|
|||
| To fix this example, we derive `PartialEq` and `Eq`. | |||
| Only structural-match types (that is, types that derive `PartialEq` and `Eq`) | |||
| may be used as the types of const generic parameters. | |||
There was a problem hiding this comment.
Suggested change
| may be used as the types of const generic parameters. | |
| may be used as the type of const generic parameters. |
Is using type here more correct?
Or maybe we can change the wording a bit.
Const generic parameters must be structural-match types (types that derive
PartialEqandEq).
Not sure if must be is the right wording. Or maybe must be structural matchable (...)?
There was a problem hiding this comment.
I *think* the current wording is correct. It's actually hard to phrase it haha.
|
@bors: r=pickfire rollup |
|
📌 Commit 1a6730e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 1, 2020
…arth Rollup of 6 pull requests Successful merges: - rust-lang#74977 (Clean up E0741 error explanation) - rust-lang#74981 (Some fixes for `plugin.md` in unstable-book) - rust-lang#74983 (Replace a recursive algorithm with an iterative one and a stack.) - rust-lang#74995 (Update the WASI libc build to LLVM 10.) - rust-lang#74996 (submodules: update cargo from 974eb438d to 2d5c2381e) - rust-lang#75007 (Clean up E0743 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC