Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ayu theme: Use different background color for Run button #74501

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jul 19, 2020

Make it clearer that there is a button Run there.

Demo in #74501 (comment) .

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jul 19, 2020

I copy the rule from #74371.

@Cldfire
Copy link
Contributor

Cldfire commented Jul 19, 2020

Good idea! I agree that the run button should have a backing to make it easily recognizable.

I don't like the outline, though. It feels very out-of-place. I would prefer it if we went with something like this:

a.test-arrow {
	font-size: 100%;
	color: #788797;
	border-radius: 4px;
	background-color: rgba(57,175,215,0.09);
}

a.test-arrow:hover {
	background-color: rgba(57,175,215,0.368);
	color: #c5c5c5;
}

Which looks like:

image

This is also more in line with what the existing themes do, and it works better on mobile aspect ratios:

image

The outline approach makes this even harder to read.

Copy link
Contributor

@Cldfire Cldfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2020

📌 Commit 0eff3d5 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
@tesuji tesuji changed the title Add an border around the Run button Ayu theme: Use different background color for Run button Jul 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2020
…arth

Rollup of 13 pull requests

Successful merges:

 - rust-lang#72714 (Fix debug assertion in typeck)
 - rust-lang#73197 (Impl Default for ranges)
 - rust-lang#73323 (wf: check foreign fn decls for well-formedness)
 - rust-lang#74051 (disallow non-static lifetimes in const generics)
 - rust-lang#74376 (test caching opt_const_param_of on disc)
 - rust-lang#74501 (Ayu theme: Use different background color for Run button)
 - rust-lang#74505 (Fix search input focus in ayu theme)
 - rust-lang#74522 (Update sanitizer docs)
 - rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute)
 - rust-lang#74552 (Stabilize TAU constant.)
 - rust-lang#74555 (Improve "important traits" popup display on mobile)
 - rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern)
 - rust-lang#74561 (update backtrace-rs)

Failed merges:

r? @ghost
@bors bors merged commit e0fae89 into rust-lang:master Jul 21, 2020
@tesuji tesuji deleted the css_run_border branch July 21, 2020 02:21
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants