Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate confusing "globals" terminology. #74079

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Eliminate confusing "globals" terminology. #74079

merged 1 commit into from
Jul 10, 2020

Commits on Jul 9, 2020

  1. Eliminate confusing "globals" terminology. 

    There are some structures that are called "globals", but are they global
to a compilation session, and not truly global. I have always found this
highly confusing, so this commit renames them as "session globals" and
adds a comment explaining things.

Also, the commit fixes an unnecessary nesting of `set()` calls
`src/librustc_errors/json/tests.rs`
    @nnethercote
    nnethercote committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    81c5bb6 View commit details
    Browse the repository at this point in the history