ci: disable alt build during try builds #73444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is not actually needed often, and it can be added back on a case-by-case basis if a specific PR needs access to it.
rust-highfive
added
the
S-waiting-on-review
|
Have we confirmed that we're not using this in any known infra (e.g. crater)? If so we probably want docs at least and maybe a crater PR to give a nicer error or so. |
|
I checked Crater and it turns out it's not using alt builds at all. I misremembered during the meeting. As far as I'm aware perf and Crater are the only two tools dealing with try builds, the other consumer of CI artifacts (bisection) only uses auto builds. |
|
Yes, I think that's correct. @bors r+ in that case. |
|
📌 Commit afde860 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 20, 2020
…ark-Simulacrum ci: disable alt build during try builds The alt build is not actually needed often, and it can be added back on a case-by-case basis if a specific PR needs access to it. This will free up a builder. r? @Mark-Simulacrum
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 20, 2020
…ark-Simulacrum ci: disable alt build during try builds The alt build is not actually needed often, and it can be added back on a case-by-case basis if a specific PR needs access to it. This will free up a builder. r? @Mark-Simulacrum
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 20, 2020
…ark-Simulacrum ci: disable alt build during try builds The alt build is not actually needed often, and it can be added back on a case-by-case basis if a specific PR needs access to it. This will free up a builder. r? @Mark-Simulacrum
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#72600 (Properly encode AnonConst into crate metadata) - rust-lang#73055 (remove leftover mentions of `skol` and `int` from the compiler) - rust-lang#73058 (Support sanitizers on aarch64-unknown-linux-gnu) - rust-lang#73171 (RISC-V Emulated Testing) - rust-lang#73404 (Update CFGuard syntax) - rust-lang#73444 (ci: disable alt build during try builds) - rust-lang#73471 (Prevent attacker from manipulating FPU tag word used in SGX enclave) - rust-lang#73539 (Deprecate `Vec::remove_item`) - rust-lang#73543 (Clean up E0695 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alt build is not actually needed often, and it can be added back on a case-by-case basis if a specific PR needs access to it.
This will free up a builder.
r? @Mark-Simulacrum