-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #73393
Rollup of 14 pull requests #73393
Commits on May 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 591584e - Browse repository at this point
Copy the full SHA 591584eView commit details
Commits on May 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3313bf6 - Browse repository at this point
Copy the full SHA 3313bf6View commit details
Commits on Jun 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e9b67d2 - Browse repository at this point
Copy the full SHA e9b67d2View commit details
Commits on Jun 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5837518 - Browse repository at this point
Copy the full SHA 5837518View commit details -
Configuration menu - View commit details
-
Copy full SHA for d684855 - Browse repository at this point
Copy the full SHA d684855View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5fdbbe - Browse repository at this point
Copy the full SHA b5fdbbeView commit details -
Preserve expressions that get a
DefId
Namely closures and `async` blocks. We have to make a few modifications to closures to make them compile.
Configuration menu - View commit details
-
Copy full SHA for d8c99f3 - Browse repository at this point
Copy the full SHA d8c99f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a30042 - Browse repository at this point
Copy the full SHA 1a30042View commit details -
Configuration menu - View commit details
-
Copy full SHA for e319f20 - Browse repository at this point
Copy the full SHA e319f20View commit details
Commits on Jun 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bbb3321 - Browse repository at this point
Copy the full SHA bbb3321View commit details
Commits on Jun 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2af53e9 - Browse repository at this point
Copy the full SHA 2af53e9View commit details
Commits on Jun 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 01e29c7 - Browse repository at this point
Copy the full SHA 01e29c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0687b78 - Browse repository at this point
Copy the full SHA 0687b78View commit details
Commits on Jun 14, 2020
-
Ignore overflow when finding auto-trait impls in Rustdoc
In rust-lang#72936 (comment), it was determined that some unusual code could cause rustc to overflow when evaluating a predicate of the form `T: AutoTrait`. Even if this is a bug, it will still be possible to cause overflow through writing explicit impls of auto traits, just like any other type of impl. In rustdoc, this overflow can happen simply as a result of defining certain types, since we will automatically generate and evaluate auto-trait predicates when generating documentation. For now, we just ignore overflow during selection if it occurs in rustdoc. We should probably come up with a better way to handle this - e.g. rendering some kind of error in the generated documentation. However, this is a very unusual corner case, and this PR is sufficient to unblock landing a Chalk update in PR rust-lang#72936 This adds additional hacks to `librustc_trait_selection`. The auto-trait-finding code should probably be completely rewritten, but I think this is good enough for the time being.
Configuration menu - View commit details
-
Copy full SHA for 561107c - Browse repository at this point
Copy the full SHA 561107cView commit details -
Switch bootstrap metadata to --no-deps.
This should run much faster. There are also some drive-by cleanups here to try to simplify things. Also, the paths for in-tree crates are now displayed as relative in `x.py test -h -v`.
Configuration menu - View commit details
-
Copy full SHA for 607e851 - Browse repository at this point
Copy the full SHA 607e851View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2b920f - Browse repository at this point
Copy the full SHA c2b920fView commit details
Commits on Jun 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f17fd7b - Browse repository at this point
Copy the full SHA f17fd7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64a6de2 - Browse repository at this point
Copy the full SHA 64a6de2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e51008 - Browse repository at this point
Copy the full SHA 9e51008View commit details -
Configuration menu - View commit details
-
Copy full SHA for b67bdb5 - Browse repository at this point
Copy the full SHA b67bdb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7456c - Browse repository at this point
Copy the full SHA fe7456cView commit details -
Tweak "non-primitive cast" error
- Suggest borrowing expression if it would allow cast to work. - Suggest using `<Type>::from(<expr>)` when appropriate. - Minor tweak to `;` typo suggestion. Partily address rust-lang#47136.
Configuration menu - View commit details
-
Copy full SHA for e857696 - Browse repository at this point
Copy the full SHA e857696View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81c9094 - Browse repository at this point
Copy the full SHA 81c9094View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e90f17 - Browse repository at this point
Copy the full SHA 4e90f17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 921f35f - Browse repository at this point
Copy the full SHA 921f35fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e755889 - Browse repository at this point
Copy the full SHA e755889View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc15790 - Browse repository at this point
Copy the full SHA bc15790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 539e978 - Browse repository at this point
Copy the full SHA 539e978View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31ea589 - Browse repository at this point
Copy the full SHA 31ea589View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d9bf1 - Browse repository at this point
Copy the full SHA 10d9bf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d8692 - Browse repository at this point
Copy the full SHA 34d8692View commit details -
Configuration menu - View commit details
-
Copy full SHA for e31367d - Browse repository at this point
Copy the full SHA e31367dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7a1f97 - Browse repository at this point
Copy the full SHA f7a1f97View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfe1434 - Browse repository at this point
Copy the full SHA bfe1434View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4337cc - Browse repository at this point
Copy the full SHA a4337ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc13fd0 - Browse repository at this point
Copy the full SHA fc13fd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b34a417 - Browse repository at this point
Copy the full SHA b34a417View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c54db - Browse repository at this point
Copy the full SHA 71c54dbView commit details
Commits on Jun 16, 2020
-
Rollup merge of rust-lang#72628 - MikailBag:array-default-tests, r=sh…
…epmaster Add tests for 'impl Default for [T; N]' Related: rust-lang#71690. This pull request adds two tests: - Even it T::default() panics, no leaks occur. - [T; 0] is Default even if T is not. I believe at some moment `Default` impl for arrays will be rewritten to use const generics instead of macros, and these tests will help to prevent behavior changes.
Configuration menu - View commit details
-
Copy full SHA for 6dbc959 - Browse repository at this point
Copy the full SHA 6dbc959View commit details -
Rollup merge of rust-lang#72804 - estebank:opaque-missing-lts-in-fn-2…
…, r=nikomatsakis Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position * Suggest substituting `'static` lifetime in impl/dyn `Trait + 'static` instead of `Trait + 'static + '_` * When `'static` is explicit, also suggest constraining argument with it * Reduce verbosity of suggestion message and mention lifetime in label * Tweak output for overlapping required/captured spans * Give these errors an error code Follow up to rust-lang#72543. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for a23b4f5 - Browse repository at this point
Copy the full SHA a23b4f5View commit details -
Rollup merge of rust-lang#72836 - poliorcetics:std-time-os-specificit…
…ies, r=shepmaster Complete the std::time documentation to warn about the inconsistencies between OS Fix for rust-lang#48980. I put the new documentation in `src/libstd/time.rs` at the module-level because it affects all types, even the one that are not directly system dependents if they are used with affected types, but there may be a better place for it.
Configuration menu - View commit details
-
Copy full SHA for 11e9796 - Browse repository at this point
Copy the full SHA 11e9796View commit details -
Rollup merge of rust-lang#73065 - Amanieu:tls-fix, r=oli-obk
Fix link error with #[thread_local] introduced by rust-lang#71192 r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 37bc4b2 - Browse repository at this point
Copy the full SHA 37bc4b2View commit details -
Rollup merge of rust-lang#73103 - ecstatic-morse:replace-body-with-lo…
…op, r=pnkfelix Preserve `Expr`s that have `DefId`s in `ReplaceBodyWithLoop` This PR fixes rust-lang#71820 as well as the last part of rust-lang#71104 by preserving expressions that are assigned their own `DefId`s (closures and `async` blocks) when passing them to `rustdoc`. This avoids having a `DefId` without a corresponding `HirId`. The first commit in this PR makes `-Zunpretty=everybody_loops` actually work again, and the subsequent two are miscellaneous cleanup. They should probably get merged regardless of what we end up doing here. Sample input: ```rust fn foo() -> Box<i32> { let x = |a: i64| { const FOO: i64 = 1; }; let a = 4; Box::new(a) } ``` Sample output: ```rust fn foo() -> Box<i32> { || -> ! { const FOO: i64 = 1; loop { } }; loop { } } ``` r? @ghost
Configuration menu - View commit details
-
Copy full SHA for 2692953 - Browse repository at this point
Copy the full SHA 2692953View commit details -
Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay
Ensure std benchmarks get tested. This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot. Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI. Closes rust-lang#54176 Closes rust-lang#61913
Configuration menu - View commit details
-
Copy full SHA for 6f2c37a - Browse repository at this point
Copy the full SHA 6f2c37aView commit details -
Rollup merge of rust-lang#73335 - Aaron1011:fix/rustdoc-overflow, r=e…
…stebank Ignore overflow when finding auto-trait impls in Rustdoc In rust-lang#72936 (comment), it was determined that some unusual code could cause rustc to overflow when evaluating a predicate of the form `T: AutoTrait`. Even if this is a bug, it will still be possible to cause overflow through writing explicit impls of auto traits, just like any other type of impl. In rustdoc, this overflow can happen simply as a result of defining certain types, since we will automatically generate and evaluate auto-trait predicates when generating documentation. For now, we just ignore overflow during selection if it occurs in rustdoc. We should probably come up with a better way to handle this - e.g. rendering some kind of error in the generated documentation. However, this is a very unusual corner case, and this PR is sufficient to unblock landing a Chalk update in PR rust-lang#72936 This adds additional hacks to `librustc_trait_selection`. The auto-trait-finding code should probably be completely rewritten, but I think this is good enough for the time being.
Configuration menu - View commit details
-
Copy full SHA for a29bcb5 - Browse repository at this point
Copy the full SHA a29bcb5View commit details -
Rollup merge of rust-lang#73352 - ehuss:bootstrap-metadata, r=Mark-Si…
…mulacrum Speed up bootstrap a little. The bootstrap script was calling `cargo metadata` 3 times (or 6 with `-v`). This is a very expensive operation, and this attempts to avoid the extra calls. On my system, a simple command like `./x.py test -h -v` goes from about 3 seconds to 0.4. An overview of the changes: - Call `cargo metadata` only once with `--no-deps`. Optional dependencies are filtered in `in_tree_crates` (handling `profiler_builtins` and `rustc_codegen_llvm` which are driven by the config). - Remove a duplicate call to `metadata::build` when using `-v`. I'm not sure why it was there, it looks like a mistake or vestigial from previous behavior. - Remove check for `_shim`, I believe all the `_shim` crates are now gone. - Remove check for `rustc_` and `*san` for `test::Crate::should_run`, these are no longer dependencies in the `test` tree. - Use relative paths in `./x.py test -h -v` output. - Some code cleanup (remove unnecessary `find_compiler_crates`, etc.). - Show suite paths (`src/test/ui/...`) in `./x.py test -h -v` output. - Some doc comments.
Configuration menu - View commit details
-
Copy full SHA for 1aa70c5 - Browse repository at this point
Copy the full SHA 1aa70c5View commit details -
Rollup merge of rust-lang#73357 - petrochenkov:tmap, r=davidtwco
Use `LocalDefId` for import IDs in trait map cc rust-lang#73291 (comment)
Configuration menu - View commit details
-
Copy full SHA for 788c41a - Browse repository at this point
Copy the full SHA 788c41aView commit details -
Rollup merge of rust-lang#73361 - estebank:non-primitive-cast, r=davi…
…dtwco Tweak "non-primitive cast" error - Suggest borrowing expression if it would allow cast to work. - Suggest using `<Type>::from(<expr>)` when appropriate. - Minor tweak to `;` typo suggestion. Partily address rust-lang#47136.
Configuration menu - View commit details
-
Copy full SHA for f233e26 - Browse repository at this point
Copy the full SHA f233e26View commit details -
Rollup merge of rust-lang#73372 - GuillaumeGomez:re-order-sidebar-sec…
…tions, r=kinnison Re-order correctly the sections in the sidebar Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content". r? @kinnison
Configuration menu - View commit details
-
Copy full SHA for 8b28a7b - Browse repository at this point
Copy the full SHA 8b28a7bView commit details -
Rollup merge of rust-lang#73373 - lzutao:bug-trackcaller, r=Amanieu
Use track caller for bug! macro
Configuration menu - View commit details
-
Copy full SHA for 7f2e169 - Browse repository at this point
Copy the full SHA 7f2e169View commit details -
Rollup merge of rust-lang#73380 - pnkfelix:make-bootstrap-help-print-…
…num-cpus, r=Mark-Simulacrum Add more info to `x.py build --help` on default value for `-j JOBS`.
Configuration menu - View commit details
-
Copy full SHA for fdde082 - Browse repository at this point
Copy the full SHA fdde082View commit details -
Rollup merge of rust-lang#73381 - ratijas:fix-typo-std-mem, r=jonas-s…
…chievink Fix typo in docs of std::mem
Configuration menu - View commit details
-
Copy full SHA for 01f32ee - Browse repository at this point
Copy the full SHA 01f32eeView commit details