[WIP] Encode more info about order-dependence of linker arguments #71081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☔ The latest upstream changes (presumably #71023) made this pull request unmergeable. Please resolve the merge conflicts. |
mati865
reviewed
Apr 13, 2020
| /// These options cannot be overridden once specified. | ||
| /// So they can be passed anywhere on the command line. | ||
| pub unordered_non_overridable: Vec<String>, | ||
| /// These option can be overridden by options placed to the left from them on the command line. |
There was a problem hiding this comment.
Suggested change
| /// These option can be overridden by options placed to the left from them on the command line. | |
| /// These options can be overridden by options placed to the left from them on the command line. |
| /// So they need to be placed after customization points like `-C link-args`. | ||
| /// (Library search directories traversed from left to right is a typical example.) | ||
| pub unordered_left_overridable: Vec<String>, | ||
| /// These option can be overridden by options placed to the right from them on the command line. |
There was a problem hiding this comment.
Suggested change
| /// These option can be overridden by options placed to the right from them on the command line. | |
| /// These options can be overridden by options placed to the right from them on the command line. |
petrochenkov
added
the
T-compiler
bjorn3
reviewed
Apr 15, 2020
| singlethread: true, | ||
| linker: Some("rust-lld".to_string()), | ||
| // FIXME: This should likely be `true` inherited from `msvc_base` | ||
| // because UEFI follows Windows ABI and uses PE/COFF. |
There was a problem hiding this comment.
It doesn't om RISC-V as there is no windows abi.
There was a problem hiding this comment.
Funnily enough, Windows NT was originally developed for RISC processors.
There was a problem hiding this comment.
We don't have a RISC-V UEFI target though, this is a base for x86_64/i686.
The RISC-V target will need a separate "base" then.
petrochenkov
force-pushed
the
linkorder3
branch
from
ec7e976
to
4f9aa69
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
petrochenkov
added
S-waiting-on-author
|
@petrochenkov any updates? |
|
Closing for now, there are more urgent things to do in this area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #71030, only the last commit is new.
This is a continuation of #70868.
So, the goals are (copypaste):
-C link-argsand-Z pre-link-args.-Z pre-link-arg(s)as-C pre-link-arg(s)#70505).This PR starts with target specifications for MSVC-based targets specifically.
r? @nagisa