Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in operands section #70715

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix typo in operands section #70715

merged 2 commits into from
Apr 3, 2020

Conversation

ab22593k
Copy link
Contributor

@ab22593k ab22593k commented Apr 2, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2020
@jonas-schievink
Copy link
Contributor

An lvalue is a value that identifies a memory location. I think this terminology was changed to "place" at some point, so maybe that would be better here.

@ab22593k
Copy link
Contributor Author

ab22593k commented Apr 2, 2020

Misunderstanding thanks @jonas-schievink, should i close this PR.

@jonas-schievink
Copy link
Contributor

You can also change it to say "place" instead, but I'm not sure how widespread that wording is either. It's documented in the reference at least: https://doc.rust-lang.org/reference/expressions.html?highlight=lvalue#place-expressions-and-value-expressions

@ab22593k
Copy link
Contributor Author

ab22593k commented Apr 2, 2020

I make a quick search and i find this terminology is unique

@ab22593k ab22593k changed the title fix type in operands section Fix typo in operands section Apr 2, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 2, 2020

📌 Commit 56918e5 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2020
@Centril Centril mentioned this pull request Apr 3, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2020
@bors
Auto merge of rust-lang#70726 - Centril:rollup-zrdkkpt, r=Centril
548afdb 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#68334 (AArch64 bare-metal targets: Build rust-std)
 - rust-lang#70224 (Clean up rustdoc js testers)
 - rust-lang#70532 (Miri engine: stronger type-based sanity check for assignments)
 - rust-lang#70698 (bootstrap: add `--json-output` for rust-analyzer)
 - rust-lang#70715 (Fix typo in operands section)

Failed merges:

r? @ghost
@bors bors merged commit c2372f1 into rust-lang:master Apr 3, 2020
@ab22593k ab22593k deleted the patch-1 branch April 3, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ab22593k @rust-highfive @jonas-schievink @Dylan-DPC-zz @bors @QuietMisdreavus