remove lifetimes that can be elided (clippy::needless_lifetimes) #69809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @rust-lang/compiler Don't we have a regular lint that also does this? I remember wanting to do something like this then hitting some sort of issue. |
eddyb
reviewed
Mar 12, 2020
src/librustc_codegen_llvm/common.rs
Outdated
| @@ -320,7 +320,7 @@ impl ConstMethods<'tcx> for CodegenCx<'ll, 'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| pub fn val_ty(v: &'ll Value) -> &'ll Type { | |||
| pub fn val_ty(v: &Value) -> &'_ Type { | |||
There was a problem hiding this comment.
This is weird, shouldn't be -> &Type?
eddyb
reviewed
Mar 12, 2020
| @@ -203,7 +203,7 @@ pub fn get_param(llfn: &'a Value, index: c_uint) -> &'a Value { | |||
| } | |||
|
|
|||
| /// Safe wrapper for `LLVMGetValueName2` into a byte slice | |||
| pub fn get_value_name(value: &'a Value) -> &'a [u8] { | |||
| pub fn get_value_name(value: &Value) -> &'_ [u8] { | |||
There was a problem hiding this comment.
More examples here, maybe search for &'_ and replace them?
eddyb
reviewed
Mar 12, 2020
| Some(&self.tcx.hir()) | ||
| } | ||
|
|
||
| fn pp_ann<'a>(&'a self) -> &'a dyn pprust_hir::PpAnn { | ||
| fn pp_ann(&self) -> &dyn pprust_hir::PpAnn { |
There was a problem hiding this comment.
Hmm none of the changes in this file seem to create &'_ .
eddyb
approved these changes
Mar 12, 2020
|
Ah, I must be thinking of (coincidentally got notified of that issue just now) |
|
Right, removed the redundant anonymous lifetimes |
eddyb
approved these changes
Mar 12, 2020
|
@bors r+ |
|
📌 Commit 7b1b08c has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 12, 2020
remove lifetimes that can be elided (clippy::needless_lifetimes)
bors
added a commit
that referenced
this pull request
Mar 13, 2020
Rollup of 8 pull requests Successful merges: - #68746 (Make macro metavars respect (non-)hygiene) - #69189 (Erase regions in writeback) - #69402 (Extend search) - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69949 (triagebot.toml: add ping aliases) Failed merges: - #69589 (ast: `Mac`/`Macro` -> `MacCall`) r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 13, 2020
remove lifetimes that can be elided (clippy::needless_lifetimes)
bors
added a commit
that referenced
this pull request
Mar 13, 2020
Rollup of 12 pull requests Successful merges: - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69723 (Added doc on keyword Pub.) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69947 (Clean up E0423 explanation) - #69949 (triagebot.toml: add ping aliases) - #69954 (rename panic_if_ intrinsics to assert_) - #69960 (miri engine: fix treatment of abort intrinsic) - #69966 (Add more regression tests) - #69973 (Update stable-since version for const_int_conversion) - #69974 (Clean up E0434 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.